Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add general part #2035

Merged
merged 32 commits into from
Jan 13, 2025
Merged

Add general part #2035

merged 32 commits into from
Jan 13, 2025

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Jan 6, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • New function general_partition to calculate partition of uncertainty over a given list of dimensions.

Does this PR introduce a breaking change?

no

Other information:

Developped for "On the importance of the reference data: Uncertainty partitioning of bias-adjusted climate simulations over Quebec" by Lavoie et al. (submitted in 2024) (presented at the last jamboree)
Code for the paper here: https://github.com/Ouranosinc/partition

Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks, but it looks good AFAICT. I'll leave someone to give you the go-ahead.

CHANGELOG.rst Outdated Show resolved Hide resolved
src/xclim/ensembles/_partitioning.py Outdated Show resolved Hide resolved
src/xclim/ensembles/_partitioning.py Outdated Show resolved Hide resolved
src/xclim/ensembles/_partitioning.py Outdated Show resolved Hide resolved
src/xclim/ensembles/_partitioning.py Outdated Show resolved Hide resolved
src/xclim/ensembles/_partitioning.py Outdated Show resolved Hide resolved
src/xclim/ensembles/_partitioning.py Outdated Show resolved Hide resolved
@Zeitsperre Zeitsperre requested a review from aulemahal January 8, 2025 18:49
@github-actions github-actions bot added the approved Approved for additional tests label Jan 8, 2025
@coveralls
Copy link

Coverage Status

coverage: 89.726% (-0.01%) from 89.737%
when pulling 7e09f65 on add_general_part
into b73841a on main.

@juliettelavoie
Copy link
Contributor Author

FYI, I am trying to re-run the code for my paper with this and the xscen updated branches to make sure I get the same as with my old env. I am having a few issues with dask. I will merge this when I fix my issues and can confirm that the my code is reproducible.

@juliettelavoie juliettelavoie merged commit af8e88f into main Jan 13, 2025
30 checks passed
@juliettelavoie juliettelavoie deleted the add_general_part branch January 13, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants