cran comments for v1.4.0 release

ref #562
OuhscBbmc · Jan 11, 2025 · 5b723e4 · 5b723e4
1 parent 22b2074
commit 5b723e4
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/cran-comments.md b/cran-comments.md
@@ -1,22 +1,25 @@
 Description
 ===============================================
 
-This submission is primarily to address a failing test.
-One of the test (out of hundreds) was missing `testthat::skip_on_cran()`.
+This submission is primarily to address vignettes were calling an external server.
+When that dev server had maintenance on
+[Dec 13](https://www.stats.ox.ac.uk/pub/bdr/Rblas/MKL/REDCapR.out), Brian Ripley requested that
+the vignettes be modified to comply with the CRAN policy that states
+no external sources should be called.
 
 Thank you for taking the time to review my submission, and please tell me if there's something else I should do for CRAN.  -Will Beasley
 
 Test environments
 -----------------------------------------------
 
-1. Local Ubuntu, R 4.4.1
-2. Local Win11, R 4.4.1 patched
+1. Local Ubuntu, R 4.4.2
+2. Local Win11, R 4.4.2 patched
 3. R-hub
-    1. [Ubuntu Linux, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/11469699615/job/31917444604)
-    2. [Windows Server, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/11469699615/job/31917445020)
-    3. [MacOS, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/11469699615/job/31917445170)
-4. [win-builder](https://win-builder.r-project.org/7m12AMR9sIC2//), development version.
-5. [GiHub Actions R-CMD-check](https://github.com/OuhscBbmc/REDCapR/actions/workflows/check-release.yaml), Ubuntu 22.04 LTS
+    1. [Ubuntu Linux, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/12719261459/job/35459171237)
+    2. [Windows Server, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/12719261459/job/35459171426)
+    3. [MacOS, R-devel](https://github.com/OuhscBbmc/REDCapR/actions/runs/12719261459/job/35459171708)
+4. [win-builder](https://win-builder.r-project.org/O603j9cGa700), development version.
+5. [GiHub Actions R-CMD-check](https://github.com/OuhscBbmc/REDCapR/actions/workflows/check-release.yaml), Ubuntu 24.04 LTS
 
 R CMD check results
 -----------------------------------------------