-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix engine bug #329
Merged
lslzl3000
merged 42 commits into
Orillusion:dev
from
X-OldGentleMan:dev-0.7.2-GraphicFace
Nov 14, 2023
Merged
fix: fix engine bug #329
lslzl3000
merged 42 commits into
Orillusion:dev
from
X-OldGentleMan:dev-0.7.2-GraphicFace
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix gltf sample fix emissive color
fix image material fix chromaKey material
fix grass sample
fix resize
fix canvas resize change gpu attachments texture
fix resize events
fix sample grass
fix post sample resize bug
Fix csm shadow.
add sample
…an/orillusion into dev-0.71-GraphicTri
Cancel automatic resizing of rendertexture in GI
add graphic ribbon
…an/orillusion into dev-0.71-GraphicTri
Fix wrong offset for bloom.
…usion into dev-0.71-GraphicTri
Reduce texture sample times in GI lightingPass.
fix: texture Count Exceeded the maximum limit of 7
Move GodRay setting from post file to engine setting.
Get param from setting.
add new graphic face
Codeboy-cn
approved these changes
Nov 14, 2023
…llusion into dev-0.7.2-GraphicFace
…llusion into dev-0.7.2-GraphicFace
lslzl3000
approved these changes
Nov 14, 2023
hellmor
reviewed
Nov 14, 2023
view.scene = this.scene; | ||
view.camera = mainCamera; | ||
Engine3D.startRenderView(view); | ||
// 1. 必须在 startRenderView 后添加 post 才可以,否则错误 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
language style
hellmor
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move GodRay setting from post file to engine setting.
Texture Count Exceeded the maximum limit of 7.
Reduce texture sample times in GI lightingPass.
Add graphic ribbon.
Fix wrong offset for bloom.
Cancel automatic resizing of rendertexture in GI.
Fix csm shadow.
Ffix post sample resize bug.