Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#179 Make OpenStemmata a Python package #183

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

clemsciences
Copy link

The main benefit of the suggested changes is to simply do pip install -e . at the root of the project to install the openstemmata project. The best would be to host the code on Pypi so that a simple pip install openstemmata will install the project.
I also made code more Pythonic. I know this is a matter of taste.
The main drawback is that I moved all the data files into src/openstemmata. This change may break all previous scripts based on this project.

The next task will be to add a built-in reader in the package (see #178).

@Jean-Baptiste-Camps
Copy link
Member

Thanks a lot for this work ! As it is an important change, I think we need to discuss it between maintainers, and see how to accomodate with them.

@Jean-Baptiste-Camps
Copy link
Member

I wonder if one option could not be to have a separate repo under OpenStemmata for the python package, and keep the 'working database' separate 🤔

@clemsciences
Copy link
Author

I think it could be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants