Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update checkpoint passwordUtil test aes128(v0) passwords to aes256(v1) #30604

Conversation

Zech-Hein
Copy link
Contributor

@Zech-Hein Zech-Hein commented Jan 22, 2025

For: #29659

@Zech-Hein Zech-Hein requested a review from tjwatson January 22, 2025 03:09
@Zech-Hein Zech-Hein self-assigned this Jan 22, 2025
@Zech-Hein
Copy link
Contributor Author

Zech-Hein commented Jan 22, 2025

#build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

Your Open Liberty Personal Build request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?pipelineId=d7762889-3ce0-40ac-98c4-a8215e41aa1b

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_RlcFENirEe-0yqtOHBleJw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 2 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_q_nj8NisEe-0yqtOHBleJw

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

@Zech-Hein Zech-Hein requested a review from tjwatson January 22, 2025 16:55
@Zech-Hein
Copy link
Contributor Author

Zech-Hein commented Jan 22, 2025

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 3 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

Copy link
Member

@tjwatson tjwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested locally with an InstantOn enabled environment. The modified tests pass. Thanks!

@LibbyBot
Copy link

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_HVKpgdk3Ee-0yqtOHBleJw

The build will run your changed FAT bucket(s) 10 times.

Target locations of links might be accessible only to IBM employees.

@Zech-Hein
Copy link
Contributor Author

PB completed with the tests passing. There was an intermittent failure that was unrelated to these changes. Proceeding with merge.

@Zech-Hein Zech-Hein merged commit 9da72ce into OpenLiberty:integration Jan 23, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants