Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce #30589 move custom dockerfiles to a central locatio #30597

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Reintroduce #30589 move custom dockerfiles to a central locatio #30597

merged 2 commits into from
Jan 23, 2025
+455 −714

Conversation

KyleAure
Copy link
Member

@KyleAure KyleAure commented Jan 21, 2025 •
edited
Loading

@KyleAure KyleAure requested a review from mswatosh January 21, 2025 14:56
@KyleAure KyleAure self-assigned this Jan 21, 2025
@KyleAure KyleAure changed the title Revert #30589 move custom dockerfiles to a central location Reintroduce #30589 move custom dockerfiles to a central locatio Jan 21, 2025
@KyleAure
Copy link
Member Author

KyleAure commented Jan 21, 2025 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 26 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 56 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • Please describe in a separate comment how you tested your changes.

@KyleAure
Copy link
Member Author

KyleAure commented Jan 21, 2025 •
edited
Loading

DB Rotation SOE: https://libh-proxy1.fyre.ibm.com/cognitive-dev/pipelineAnalysis.html?pipelineId=e8f2441d-ef57-428f-89a9-f87c04fcff52

Note: Target locations of links might be accessible only to IBM employees.

@KyleAure
Copy link
Member Author

KyleAure commented Jan 22, 2025 •
edited
Loading

Personal Build: failed with 1 known unrelated defect, and 3 intermittent timeouts (slow infrastructure)
Verified build.example.testcontainers_fat ran in full mode
DB Rotation SOE: Many timeouts.

I'm going to re-do these builds. I think the infrastructure was really slow and I want to make sure this PR didn't cause anything.

@KyleAure
Revert "Merge pull request OpenLiberty#30589 from OpenLiberty/revert-…
9f63765 
…30550-30300-relocate-dockerfiles"

This reverts commit 1ed11a1, reversing
changes made to 56d85ff.
@KyleAure
fix: restore necessary deleted files
f5bff04
@KyleAure KyleAure force-pushed the revert-revert-30300-relocate-dockerfiles branch from 17e1506 to f5bff04 Compare January 22, 2025 22:07
@KyleAure
Copy link
Member Author

KyleAure commented Jan 22, 2025 •
edited by LibbyBot
Loading

#build - redo build after fixes have gone into liberty (view Open Liberty Personal Build - ❌ completed with errors/failures.)

Note: Target locations of links might be accessible only to IBM employees.

@KyleAure
Copy link
Member Author

DB Rotation SOE: https://libh-proxy1.fyre.ibm.com/cognitive-dev/pipelineAnalysis.html?pipelineId=e2ce561c-13a4-4519-a94a-43f7b5147065

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 26 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 56 test infrastructure code files were changed.

  • Test failures/errors in the build could be due to these changes.

  • Please describe in a separate comment how you tested your changes.

@KyleAure KyleAure mentioned this pull request Jan 22, 2025
Open
3 tasks
@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_S7AmQNluEe-0yqtOHBleJw

Target locations of links might be accessible only to IBM employees.

@KyleAure
Copy link
Member Author

Personal build: 1 known unrelated defect
Database Rotation SOE: 5 known unrelated defects

@KyleAure KyleAure merged commit 13ab67d into OpenLiberty:integration Jan 23, 2025
2 of 3 checks passed
@KyleAure KyleAure deleted the revert-revert-30300-relocate-dockerfiles branch January 23, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswatosh mswatosh mswatosh approved these changes

Assignees

@KyleAure KyleAure

Labels
noproductcode team:Zombie Apocalypse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyleAure @LibbyBot @mswatosh