-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update starter #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
ajm01
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
Signed-off-by: Scott Kurz <[email protected]>
scottkurz
force-pushed
the
update-starter
branch
from
October 2, 2020 11:18
2c96208
to
0db5551
Compare
Signed-off-by: Scott Kurz <[email protected]>
This seemed more useful merged to master than holding it out but feel free to open a new issue (or otherwise contact me) with comments here. One comment from @yeekangc internally suggested removing the IT, which we'll probably do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we implement the UFO design from: OpenLiberty/open-liberty#9343
(in turn referencing in places the openliberty.io starter design: OpenLiberty/openliberty.io#1424).
There were too many details to discuss on the design call so here's an attempt to compromise and meet the goal of providing a starter, with useful code that will largely be used as-is and not deleted, rather than a sample.
The default starter shown here includes files:
Some highlights:
@ApplicationPath("/")
to match MST default forRESTClient
injection, since MST isn't currently set up to discover this annotation without additional work.@gcharters @yeekangc @gkwan-ibm @Emily-Jiang @NottyCode