Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in ConnectorServer.bat #44

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

BolivandoJJ
Copy link
Contributor

Added a space character « » to the JAVA_OPTS_DELIM parameter of the :srvRun section of the ConnectorServer.bat file.
This space is necessary to separate Java parameters when starting server with the /run key.
If there is no separator, the parameters are concatenated into one line without spaces and simply do not work.
I encountered this bug when I tried to set up a secure connection to the OpenICF connector server via SSL. Example from usage: «ConnectorServer.bat /run "-J-Djavax.net.ssl.keyStore=keystore.jks" "-J-Djavax.net.ssl.keyStorePassword=changeit"» does not work for this reason.
I found the error very confusing, because in normal mode the connector server does not output any errors to the console related to this bug.

…srvRun section of the ConnectorServer.bat file.

This space is necessary to separate Java parameters when starting server with the /run key.
If there is no separator, the parameters are concatenated into one line without spaces and simply do not work.
I encountered this bug when I tried to set up a secure connection to the OpenICF connector server via SSL. Example from usage: «ConnectorServer.bat /run "-J-Djavax.net.ssl.keyStore=keystore.jks" "-J-Djavax.net.ssl.keyStorePassword=changeit"» does not work for this reason.
I found the error very confusing, because in normal mode the connector server does not output any errors to the console related to this bug.
@vharseko vharseko merged commit ee8167b into OpenIdentityPlatform:master Sep 24, 2024
17 checks passed
@vharseko
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants