📖✨：add shallow-page & deep-page views #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for open-inf-is processing.
|
|
this is in relation to #1184 and should support that page properly; i am thinking that docs should instead extend deep-page layout |
DerekNonGeneric
commented
Mar 25, 2024
|
oh dang, looks like another 🔥 approach: 🔗 https://cogitorium.info/2021/04/jekyll-structured-breadcrumbs (and those 🗾 chevrons have me like 😅) |
DerekNonGeneric
commented
Mar 25, 2024
| {%- if page.permalink != '/' -%} | ||
| <h1 class="page-heading">{{ page.title }}</h1> | ||
| {%- endif -%} | ||
| {{ content }} |
There was a problem hiding this comment.
another conditional being page.toc != false
DerekNonGeneric
added
🔥 P0: Critical
|
okay, how to preview is one thing i am thinking about… |
DerekNonGeneric
changed the title
|
anyone else seen the Jekyll Style Guide? 🔗 https://jekyllstyleguide.com
|
DerekNonGeneric
added
the
🚅 Status: Fast Track
DerekNonGeneric
force-pushed
the
live
branch
4 times, most recently
from
c5427e7 to
8c69b01
Compare
✅ Deploy Preview for openinfis ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
OpenINFbot
requested changes
Mar 28, 2024
There was a problem hiding this comment.
newly-issued side-convo @ https://github.com/OpenINF/openinf.github.io/issues/1235
OpenINFbot
reviewed
Mar 29, 2024
_includes/breadcrumbs.html
Outdated
| {% if forloop.last %} | ||
| / {{ page.title }} | ||
| {% else %} | ||
| / <a href="{% assign crumb_limit = forloop.index | plus: 1 %}{% for crumb in crumbs limit: crumb_limit %}{{ crumb | append: '/' | replace:'without-plugin/','without-plugins/' }}{% endfor %}">{{ crumb | replace:'-',' ' | remove:'.html' | capitalize }}</a> |
There was a problem hiding this comment.
Suggested change
| / <a href="{% assign crumb_limit = forloop.index | plus: 1 %}{% for crumb in crumbs limit: crumb_limit %}{{ crumb | append: '/' | replace:'without-plugin/','without-plugins/' }}{% endfor %}">{{ crumb | replace:'-',' ' | remove:'.html' | capitalize }}</a> | |
| / <a href="{% assign crumb_limit = forloop.index | plus: 1 %}{% for crumb in crumbs limit: crumb_limit %}{{ crumb | append: '/' }}{% endfor %}">{{ crumb | replace:'-',' ' | remove:'.html' | capitalize }}</a> |
Signed-off-by: OpenINF-bot <[email protected]>
Signed-off-by: OpenINF-bot <[email protected]>
Signed-off-by: OpenINF-bot <[email protected]>
OpenINFbot
reviewed
Mar 29, 2024
Signed-off-by: OpenINF-bot <[email protected]>
OpenINFbot
reviewed
Mar 29, 2024
_includes/head.html
Outdated
| @@ -1,30 +0,0 @@ | |||
| <head> | |||
There was a problem hiding this comment.
apologies, that was clearly overkill!
This reverts commit 1a3c92f.
we like this feature, but have no use for the metadata anymore Signed-off-by: OpenINF-bot <[email protected]>
OpenINFbot
reviewed
Mar 29, 2024
Signed-off-by: OpenINF-bot <[email protected]>
OpenINFbot
requested changes
Mar 29, 2024
OpenINFbot
approved these changes
Mar 29, 2024
DerekNonGeneric
commented
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP of adding page & deep-page layouts for integration