Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗🔧:reconfigure vscode for smoother startup #696

Merged
merged 19 commits into from
Feb 8, 2024

Conversation

DerekNonGeneric
Copy link
Member

@DerekNonGeneric DerekNonGeneric commented Jan 31, 2024

opening this as a WIP (still looking at a few things),
but the culprit extension (dprint) is not haunting
anymore (at least); this is intermediate tho

Pull Request Purpose

Make a selection on the purpose(s) of your changes.

This PR contains the following:

  • 🐞🔧 bugfixing (🐜/🦟/🐛/🦗/🐝 et al.)
  • 🆕🎏 implementation of new feature(s)
  • ♻️ refactoring(s)
  • 📄 documentation modification(s)
  • 🔮 other

Testing

Have you included any tests in your submission?

  • yes (bugfixes and features will not be merged without
    tests
    )
  • no

Breaking Changes

Have you modified any aspect public API surface (i.e., caused breakage)?

  • yes (breaking changes will not be merged unless
    necessary
    )
  • no

Description

A concise recap summarily detailing what all are the changes being made.

A follow-up to the recent previous corrections to the VS Code settings.

List of any relevant issue numbers:

.vscode/settings.json Outdated Show resolved Hide resolved
@DerekNonGeneric
Copy link
Member Author

many terminal options missing…

fix incoming

🔗 https://code.visualstudio.com/docs/getstarted/settings

.vscode/settings.json Outdated Show resolved Hide resolved
@DerekNonGeneric DerekNonGeneric added fast-track PRs that do not need to wait for 48 hours to land 🔧 Type: Maintenance undefined labels Feb 1, 2024
// "remoteUser": "root"
// Uncomment to connect as root instead.
// More info: https://aka.ms/dev-containers-non-root.
"remoteUser": "node"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"remoteUser": "node"
"remoteUser": "node"

i need to validate this, so maybe we run it before committing alll these changes

This comment was marked as resolved.

Copy link
Member Author

@DerekNonGeneric DerekNonGeneric Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here are the only choices that make sense to me/us, what's the deal w/ a user named "node" (?), ugh:

Suggested change
"remoteUser": "node"
"remoteUser": "dory"
Suggested change
"remoteUser": "node"
"remoteUser": "nemo"

you would think i would know, right? ahaha, those Microsofters working on VS Code is my current best guess…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo!

@DerekNonGeneric DerekNonGeneric added todo PRs that add code with TODO comments wip Issues and PRs that are still a work in progress labels Feb 1, 2024
@OpenINFbot OpenINFbot force-pushed the fix/polish-vscode-settings branch from 276459d to 219c252 Compare February 6, 2024 12:32
@OpenINFbot OpenINFbot force-pushed the fix/polish-vscode-settings branch from 219c252 to 0c25b09 Compare February 8, 2024 01:59
.vscode/settings.json Outdated Show resolved Hide resolved
Copy link
Member

@OpenINFbot OpenINFbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should have been merged yesterday!

@OpenINFbot OpenINFbot merged commit 5b8b356 into OpenINF:main Feb 8, 2024
5 checks passed
@OpenINFbot OpenINFbot removed wip Issues and PRs that are still a work in progress fast-track PRs that do not need to wait for 48 hours to land 🚧 Status: Work In Progress (WIP) undefined 🔧 Type: Maintenance undefined labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo PRs that add code with TODO comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants