Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support MSYS2/GCC #875

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jalius
Copy link

@jalius jalius commented Nov 27, 2024

Adding build support for MSYS2/GCC and cleaning up some various build errors.

  • Fix implementation of osal_thread_create() to match declaration.
  • Fix missing timezone struct declaration.
  • Add GCC style struct packing
  • Update CMakeLists with non-MSVC win32 build instructions
  • Address some compiler warnings arising from unused parameters and variables.
  • Remove stdint.h and inttypes.h which are MSVC specific. The compiler should find these standard library files based on the target rather than including them in the project.

It now builds properly on MSYS2/GCC using cmake generators "MSYS Makefiles" and "Ninja".

I didn't get a chance to build it again with MSVC, so should probably do that before merging.

@jalius
Copy link
Author

jalius commented Nov 28, 2024

Wondering if we should change
int osal_thread_create(void *thandle, int stacksize, void *func, void *param)
parameter void *thandle to OSAL_THREAD_HANDLE *thandle
for clarity in all implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant