Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eduID servicedesk role #469

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Add eduID servicedesk role #469

merged 2 commits into from
Jan 23, 2025
+38 −0

Conversation

phavekes
Copy link
Member

No description provided.

@phavekes phavekes requested a review from quartje January 21, 2025 09:44
quartje
quartje reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@quartje quartje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've based your PR on an obsolete role that is to be deleted in pr #468.
That should make this quite easier

roles/servicedesk-gui/defaults/main.yml Outdated Show resolved Hide resolved
roles/servicedesk-gui/handlers/main.yml Outdated Show resolved Hide resolved
roles/servicedesk-gui/tasks/main.yml Outdated Show resolved Hide resolved
roles/servicedesk-gui/templates/account.conf.j2 Outdated Show resolved Hide resolved
roles/servicedesk-gui/vars/main.yml Outdated Show resolved Hide resolved
roles/springboot/defaults/main.yml Outdated Show resolved Hide resolved
@phavekes phavekes requested a review from quartje January 21, 2025 10:40
@phavekes phavekes force-pushed the feature/eduid-servicedesk branch from b92131e to 8c84e2b Compare January 23, 2025 10:48
@phavekes phavekes merged commit 0722ed7 into main Jan 23, 2025
2 checks passed
@phavekes phavekes deleted the feature/eduid-servicedesk branch January 23, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartje quartje Awaiting requested review from quartje

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phavekes @quartje