-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cyton impedance check board configuration #1211
Open
philippitts
wants to merge
3
commits into
development
Choose a base branch
from
1204-cyton-impedance-checks-incorrect-at-low-resistances
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.openbci.com/GettingStarted/Biosensing-Setups/EMGSetup/#obtain-emg-data-with-openbci-cyton-board
While this may work, it also seems like this may break checking impedances when doing EMG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relates to #1058
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not matter if you are reading EMG or EEG. The impedance check remains the same and measures the impedance of one Cyton electrode against SRB2, regardless of where that electrode is placed. Per the tests above, BIAS should never be used for impedance checks. This makes sense because BIAS is used as input to the ADS1299 to create destructive interference patterns that reduce noise vs SRB2 which is the reference point against which a channel can be measured (usually for EEG).
If you look at my readings from the linked issue you can see that on almost all the BIAS tests the signal was steadily dropping. This is because the ADS1299 is canceling out the "common noise" it's reading from the BIAS pin.
EMG doesn't use SRB2 while acquiring signals because EMG references against a second EMG channel (in most cases), but to measure impedance, SRB2 must still be used. The easiest method is to switch the BIAS electrode to SRB2 for impedance measurements and switch it back to BIAS for signal acquisition.