-Fix tons of allocations happening when decompressing packets

Oliver-makes-code · Dec 7, 2023 · 9cde4ee · 9cde4ee
1 parent cc4c7d2
commit 9cde4ee
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/Common/Util/Serialization/Compressed/CompressedVDataReader.cs b/Common/Util/Serialization/Compressed/CompressedVDataReader.cs
@@ -1,3 +1,4 @@
+using System.Buffers;
 using ZstdSharp;
 
 namespace Common.Util.Serialization.Compressed;
@@ -9,7 +10,11 @@ public override void LoadData(Span<byte> data) {
         using var decompressor = new Decompressor();
 
         var expectedSize = Decompressor.GetDecompressedSize(data);
+        var rented = ArrayPool<byte>.Shared.Rent((int)expectedSize);
 
-        base.LoadData(decompressor.Unwrap(data)); //TODO - Allocation here...
+        decompressor.Unwrap(data, rented.AsSpan());
+        base.LoadData(rented);
+
+        ArrayPool<byte>.Shared.Return(rented);
     }
 }
diff --git a/Common/Util/Serialization/VDataReader.cs b/Common/Util/Serialization/VDataReader.cs
@@ -25,7 +25,7 @@ public VDataReader(byte[]? data = null) {
         dataBuffer = data ?? new byte[256];
     }
 
-    private void EnsureSize(int size) {
+    protected void EnsureSize(int size) {
         //TODO - replace with single CNPOT instead of while loop.
         while (dataBuffer.Length < size) {
             var oldBytes = dataBuffer;