refactor: pass chain id instead of provider into function (#2171)

OffchainLabs · Jan 10, 2025 · 592cdac · 592cdac
1 parent f855d56
commit 592cdac
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 31 deletions.
diff --git a/packages/arb-token-bridge-ui/src/hooks/useTransactionHistory.ts b/packages/arb-token-bridge-ui/src/hooks/useTransactionHistory.ts
@@ -161,13 +161,7 @@ async function transformTransaction(tx: Transfer): Promise<MergedTransaction> {
   }
 
   if (isDeposit(tx)) {
-    return transformDeposit(
-      await updateAdditionalDepositData({
-        depositTx: tx,
-        parentProvider,
-        childProvider
-      })
-    )
+    return transformDeposit(await updateAdditionalDepositData(tx))
   }
 
   let withdrawal: L2ToL1EventResultPlus | undefined

diff --git a/packages/arb-token-bridge-ui/src/util/deposits/helpers.ts b/packages/arb-token-bridge-ui/src/util/deposits/helpers.ts
@@ -31,15 +31,12 @@ import {
   normalizeTimestamp
 } from '../../state/app/utils'
 
-export const updateAdditionalDepositData = async ({
-  depositTx,
-  parentProvider,
-  childProvider
-}: {
+export const updateAdditionalDepositData = async (
   depositTx: Transaction
-  parentProvider: Provider
-  childProvider: Provider
-}): Promise<Transaction | TeleporterTransaction> => {
+): Promise<Transaction | TeleporterTransaction> => {
+  const parentProvider = getProviderForChainId(depositTx.parentChainId)
+  const childProvider = getProviderForChainId(depositTx.childChainId)
+
   // 1. for all the fetched txns, fetch the transaction receipts and update their exact status
   // 2. on the basis of those, finally calculate the status of the transaction
 

diff --git a/packages/arb-token-bridge-ui/src/util/teleports/helpers.ts b/packages/arb-token-bridge-ui/src/util/teleports/helpers.ts
@@ -70,14 +70,7 @@ export async function transformTeleportFromSubgraph(
       childChainId: Number(tx.childChainId)
     } as Transaction
 
-    const childProvider = getProviderForChainId(Number(tx.childChainId))
-    return transformDeposit(
-      await updateAdditionalDepositData({
-        depositTx,
-        parentProvider,
-        childProvider
-      })
-    )
+    return transformDeposit(await updateAdditionalDepositData(depositTx))
   }
 
   // Erc20 transfers
@@ -112,12 +105,5 @@ export async function transformTeleportFromSubgraph(
     childChainId: l3ChainId
   } as Transaction
 
-  const childProvider = getProviderForChainId(l3ChainId)
-  return transformDeposit(
-    await updateAdditionalDepositData({
-      depositTx,
-      parentProvider,
-      childProvider
-    })
-  )
+  return transformDeposit(await updateAdditionalDepositData(depositTx))
 }