util/misc: add time parser #12367
Closed
util/misc: add time parser #12367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a parser for different units of time. Acceptable values for defining time are: us: microseconds ms: milliseconds s: seconds m: minutes h: hours This is in order to have a more fine grained control over time which may be required for certain keywords and operations.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12367 +/- ##
==========================================
- Coverage 82.54% 82.50% -0.04%
==========================================
Files 912 912
Lines 258028 258198 +170
==========================================
+ Hits 212988 213027 +39
- Misses 45040 45171 +131
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24134 |
|
Victor won't accept it w/o a user so, it'll come with the linked PR itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flow.ratekeyword, for example, where one can define bytes (kb, b, mb, gb) and time (us, ms, s, m, h) as they wish. Exact same application would come for use in defining elephant flows in suricata.yaml (an exhibit for that is in Mark flow elephant/v4 #12325)Thoughts?
If this is acceptable, I thought we could merge it first.