Don't hide variant fields when is_virtual is selected #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merge your code into a feature branch for further development, as after some initial tests it seems that there is some work left to fully support variants on virtual products. Either way, many thanks for the pull request. It should be part of the upcoming release. |
|
Thank you so much for your extensive work on this. I really appreciate it! Can't wait to see this in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As discussed in issue 600 I would like to allow variants even when a product is_virtual.
Usecases for this would be for example a membership with three tiers, or an event with several ticket options.
Could you kindly consider reviewing this pull request?
Best regards,
M