feat: add "managementState" field to OTelCollector to fix ArgoCD sync issue #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dheerajodha
commented
Jan 8, 2025
dheerajodha
commented
- and also increase the replica count of TempoStack components from 1 to 3 so that they're scalable
larsks
reviewed
Jan 16, 2025
There was a problem hiding this comment.
In the future, something like this should be two different pull requests (because the two different changes aren't really related).
It would also be helpful if you were to include some information about why the lack of a managementState setting was causing issues with argocd.
|
Here is the ArgoCD error: error validating data: ValidationError(OpenTelemetryCollector.spec): missing required field "managementState" in io.opentelemetry.v1alpha1.OpenTelemetryCollector.spec |
* Currently, without the "managementState" field within the OpenTelemetry Collector, we're seeing a ValidationError in ArgoCD, causing Sync Failure. * This validationError is occuring because the "managementState" field is mandatory, and is currently missing from our spec. Signed-off-by: Dheeraj<[email protected]>
dheerajodha
force-pushed
the
add-managedState-field
branch
from
613e377 to
7a4ae04
Compare
|
Thanks for the review @larsks! |
computate
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.