Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] tms #148

Merged
merged 4 commits into from
Oct 23, 2024
Merged

[18.0][MIG] tms #148

merged 4 commits into from
Oct 23, 2024

Conversation

EdgarRetes
Copy link

@EdgarRetes EdgarRetes closed this Oct 9, 2024
@EdgarRetes EdgarRetes reopened this Oct 9, 2024
@max3903 max3903 added this to the 18.0 milestone Oct 10, 2024
@max3903 max3903 self-assigned this Oct 10, 2024
@max3903
Copy link
Member

max3903 commented Oct 10, 2024

/ocabot migration tms

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 10, 2024
Open
2 tasks
@max3903
Copy link
Member

max3903 commented Oct 10, 2024

@EdgarRetes I get this error message when accessing the Transport app:

TypeError: TMSOrder._read_group_stage_ids() missing 1 required positional argument: 'order'

@max3903 max3903 changed the title [MIG][18.0] tms [18.0][MIG] tms Oct 10, 2024
@EdgarRetes EdgarRetes force-pushed the 18.0-mig-tms branch 2 times, most recently from b945e2a to 7fb252c Compare October 11, 2024 23:11
@max3903
Copy link
Member

max3903 commented Oct 12, 2024

@EdgarRetes Something is wird with the form view of the trip:
image

@EdgarRetes EdgarRetes force-pushed the 18.0-mig-tms branch 2 times, most recently from dabf785 to 7459609 Compare October 23, 2024 14:55
@max3903
Copy link
Member

max3903 commented Oct 23, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-148-by-max3903-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e1c46cc into OCA:18.0 Oct 23, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5fc89aa. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max3903 max3903 max3903 approved these changes

Assignees

@max3903 max3903

Labels
merged 🎉 migration needs fixing needs review
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@EdgarRetes @max3903 @OCA-git-bot