Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0] [ADD] tms_account_asset #138

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

santiagordz
Copy link

@santiagordz santiagordz commented Aug 2, 2024

#127 (comment)

@marcelsavegnago I was already working in this implementation, what do you think about it? It is still not finished but i'm opening the PR so you can see it and suggest enhancements. I will take a look at OCA/account-financial-tools#1802 and migrate as much as possible.

Dependencies

@marcelsavegnago
Copy link
Member

For me, the issue with this type of implementation is that it is not generic and forces the use of TMS. Integrating the asset with the fleet should be independent of TMS. I believe that considering the generic use of things makes more sense than implementing everything in TMS.

@marcelsavegnago
Copy link
Member

Take a look at the PR I sent you. If you could review it in version 14.0, it would be better to merge it there and then port it to version 17.0. However, since the community tends to focus more on newer versions, we can migrate it to version 17 and propose it there.

@max3903
Copy link
Member

max3903 commented Oct 12, 2024

@EdgarRetes Can you rebase?

@EdgarRetes EdgarRetes force-pushed the 17.0_tms_account_asset branch from c5257e8 to b393f41 Compare October 15, 2024 20:49
@EdgarRetes EdgarRetes force-pushed the 17.0_tms_account_asset branch from b393f41 to e0c7323 Compare October 15, 2024 20:50
@max3903
Copy link
Member

max3903 commented Oct 16, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-138-by-max3903-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 107362a into OCA:17.0 Oct 16, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c59227a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants