-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0] [ADD] tms_account_asset #138
Conversation
For me, the issue with this type of implementation is that it is not generic and forces the use of TMS. Integrating the asset with the fleet should be independent of TMS. I believe that considering the generic use of things makes more sense than implementing everything in TMS. |
Take a look at the PR I sent you. If you could review it in version 14.0, it would be better to merge it there and then port it to version 17.0. However, since the community tends to focus more on newer versions, we can migrate it to version 17 and propose it there. |
770aaf6
to
513584f
Compare
2a124e8
to
5581b91
Compare
ca43743
to
5581b91
Compare
@EdgarRetes Can you rebase? |
c5257e8
to
b393f41
Compare
b393f41
to
e0c7323
Compare
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at c59227a. Thanks a lot for contributing to OCA. ❤️ |
#127 (comment)
@marcelsavegnago I was already working in this implementation, what do you think about it? It is still not finished but i'm opening the PR so you can see it and suggest enhancements. I will take a look at OCA/account-financial-tools#1802 and migrate as much as possible.
Dependencies