[16.0][IMP] queue_job: Add error handler when job fails #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @guewen, |
florentx
reviewed
Jan 9, 2025
| @@ -506,3 +509,31 @@ def _test_job(self, failure_rate=0): | |||
| _logger.info("Running test job.") | |||
| if random.random() <= failure_rate: | |||
| raise JobError("Job failed") | |||
|
|
|||
| def _call_webhook(self, **kwargs): | |||
| only_if_max_retries_reached = kwargs.get("only_if_max_retries_reached", False) | |||
There was a problem hiding this comment.
Suggested change
| only_if_max_retries_reached = kwargs.get("only_if_max_retries_reached", False) | |
| only_if_max_retries_reached = kwargs.get("only_if_max_retries_reached") |
| if only_if_max_retries_reached and (job and job.retry < job.max_retries): | ||
| return | ||
|
|
||
| webhook_url = kwargs.get("webhook_url", None) |
There was a problem hiding this comment.
Suggested change
| webhook_url = kwargs.get("webhook_url", None) | |
| webhook_url = kwargs.get("webhook_url") |
| webhook_url = kwargs.get("webhook_url", None) | ||
| if not webhook_url: | ||
| return | ||
| payload = kwargs.get("payload", None) |
There was a problem hiding this comment.
Suggested change
| payload = kwargs.get("payload", None) | |
| payload = kwargs.get("payload") |
| model = self.env["test.queue.job"] | ||
| job = model.with_delay(priority=1, max_retries=1).testing_method() | ||
| trap.assert_jobs_count(1) | ||
| with patch.object(type(job), "perform", side_effect=IOError,), patch( |
There was a problem hiding this comment.
Suggested change
| with patch.object(type(job), "perform", side_effect=IOError,), patch( | |
| with patch.object(type(job), "perform", side_effect=IOError), patch( |
Comment on lines
+906
to
+908
| action_kwargs = self.job_config.error_handler_kwargs | ||
| action_kwargs["job"] = self | ||
| action_kwargs["job"] = self |
There was a problem hiding this comment.
Duplicate line.
Can also be written as:
Suggested change
| action_kwargs = self.job_config.error_handler_kwargs | |
| action_kwargs["job"] = self | |
| action_kwargs["job"] = self | |
| action_kwargs = {**self.job_config.error_handler_kwargs, "job": self} |
| def _call_webhook(self, **kwargs): | ||
| only_if_max_retries_reached = kwargs.get("only_if_max_retries_reached", False) | ||
| job = kwargs.get("job") | ||
| if only_if_max_retries_reached and (job and job.retry < job.max_retries): |
There was a problem hiding this comment.
Suggested change
| if only_if_max_retries_reached and (job and job.retry < job.max_retries): | |
| if only_if_max_retries_reached and job and job.retry < job.max_retries: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.