Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][REF] queue_job: Use set.discard(...) instead of SafeSet #719

Merged
merged 1 commit into from
Dec 21, 2024
Merged

[14.0][REF] queue_job: Use set.discard(...) instead of SafeSet #719

merged 1 commit into from
Dec 21, 2024

Conversation

florentx
Copy link
Contributor

Simplify

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@florentx florentx changed the title [14.0] [REF] queue_job: Use set.discard(...) instead of SafeSet [14.0][REF] queue_job: Use set.discard(...) instead of SafeSet Dec 16, 2024
sbidoul
sbidoul approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Really curious why my previous self did that 10 years ago...

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sbidoul
Copy link
Member

sbidoul commented Dec 21, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-719-by-sbidoul-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 975ea6c into OCA:14.0 Dec 21, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0c55d5c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbidoul sbidoul sbidoul approved these changes

@amh-mw amh-mw amh-mw approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@florentx @OCA-git-bot @sbidoul @amh-mw