-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] queue_job: HA job runner using session level advisory lock #668
base: 16.0
Are you sure you want to change the base?
Conversation
Hi @guewen, |
02ef89b
to
deecd27
Compare
Yep, this should work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
@PCatinean do you know who we should ping in the odoo.sh team to have an opinion on this approach? |
@amigrave @sts-odoo so the TL;DR here is that we have one long lived connection to the database on which we take a session-level advisory lock and do a I plan to deploy this on a odoo.sh dev env soon to see how it goes. I can PM you the details if you wish to monitor something. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@sbidoul any feedback? |
Without this, we leak connections to Databases that don't have queue_job installed.
Without this we risk connection leaks in case of exceptions in the constructor.
b65bbc6
to
ffb27a4
Compare
Feeback given in #673 (comment). And rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
I'm going to install it on one of my projects and battle test it.
sorry, why is this not merged yet? |
I'd like to run this on my staging and production GKE cluster. I would especially like to test the scaling capabilities of this in my staging environment. If I deploy this to my staging env, would either of you like the keys to my staging env and the GKE staging cluster to kick the tires and load test this with K6 or similar tools? I would love to see this merged, and would be happy to run this in production after some load testing in staging and report back on results or allow you to monitor. I can reach out to you via email to get this going through your company's official channels if this is something you'd like to explore. |
Hi everyone. This is not merged precisely because we would like more feedback from actual deployments. Tests are ongoing at Acsone, and I would encourage others to do the same. |
Thanks. I'll get this into staging and then production and report back with findings. |
Another attempt.