-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.rst #301
base: master
Are you sure you want to change the base?
Update README.rst #301
Conversation
Add link to API Add license badge Format a little
README.rst
Outdated
.. image:: https://img.shields.io/badge/License-AGPL%20v3-blue.svg | ||
:target: https://www.gnu.org/licenses/agpl-3.0 | ||
:alt: License: AGPL v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. image:: https://img.shields.io/badge/License-AGPL%20v3-blue.svg | |
:target: https://www.gnu.org/licenses/agpl-3.0 | |
:alt: License: AGPL v3 | |
.. image:: https://img.shields.io/badge/license-AGPL--3-blue.png | |
:target: https://www.gnu.org/licenses/agpl-3.0 | |
:alt: License: AGPL-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol, I literally cut and paste that from a recommended gist - no problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I should revert the image, that png is dog ugly compared to the nice clean svg. Is there any reason we want png specifically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, as you wish. Just FYI svg files are not rendered in apps, thus I always put .png in readme files by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough reason for me, although the other images are svg's, I'll leave it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look the date of such change... I think this must be re-evaluated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well in any case, this is not an app.
Should I maybe convert to Markdown too? RST was a bit funky to edit remembering the slight syntax differences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is not an app. Let's put svg then!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And we need to review the criteria for the rest, as Odoo has evolved. First of all, we nee to know where the incompatibility was.
Per Review Co-authored-by: Miquel Raïch <[email protected]>
@gdgellatly : could you rebase and fix conflict ? |
/ocabot rebase |
@gdgellatly The rebase process failed, because command
|
Add link to API
Add license badge
Format a little