Skip to content

Commit

Permalink
[FIX] Install Chrome fixed version to avoid sudden errors
Browse files Browse the repository at this point in the history
Odoo's approach with Runbots is to install a fixed version of Chrome and
only when a new version is tested across all the supported code base
they bump it.

That way, they avoid sudden errors that would make the whole CIs
collapse on tour tests.

We can follow the guideline of Odoo's fixed versions for a minimum
guarantee.
  • Loading branch information
chienandalu committed Sep 25, 2024
1 parent f641d25 commit 1b33913
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,13 @@ RUN curl -sSL https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add -
&& apt-get update -qq \
&& DEBIAN_FRONTEND=noninteractive apt-get install -qq postgresql-client-12

# Install Google Chrome for browser tests
RUN curl -sSL https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb -o /tmp/chrome.deb \
# Install Google Chrome for browser tests with values {"chrome_version": "126.0.6478.182-1"}
# Fixed following Odoo's Runbot guideline https://github.com/odoo/runbot/commit/f18a1adfc387321dac907735e8c3a77a15b2607f
RUN case $(lsb_release -c -s) in \
focal) CHROME_DEB_URL=https://snapshot.debian.org/archive/debian-security/20240117T233842Z/pool/updates/main/c/chromium/chromium_120.0.6099.224-1~deb11u1_amd64.deb ;; \
jammy) CHROME_DEB_URL=https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_123.0.6312.58-1_amd64.deb ;; \
esac \
&& curl -sSL $CHROME_DEB_URL -o /tmp/chrome.deb \
&& apt-get -y install --no-install-recommends /tmp/chrome.deb \
&& rm /tmp/chrome.deb

Expand Down

0 comments on commit 1b33913

Please sign in to comment.