[FIX] test_server.py: Adding more validation to detected ERROR

[JesusZapata]

Relating to #447 (comment)

With this small change now travis is red if in the log has one ERROR

I made one PR of test related with this JesusZapata/project#1

And now the travis is red

Fix #447

[JesusZapata]

@dreispt @moylop260 @sbidoul
Yours comments are welcome

[dreispt]

Sometimes we test if an error is raised.
Will this incorrectly break such a build?

[JesusZapata]

@dreispt
The execution of odoo continues running without paying attention to the error
I don't know if this behaviour is the correct

[sbidoul]

I also noticed that, but I never dared to change it, as I supposed that if someone explicitly filtered on CRITICAL errors only, there must have been a reason.

FWIW, for our own CI needs, we created a script dedicated to checking odoo logs, with agressive defaults (WARNING level records are considered errors) and a regex-based mechanism to filter expected errors.

[dreispt]

To be clear, I'm not against this change as long as long as tests verifying if a Exception was raised don't incorrectly break the build.
Can you check that @JesusZapata ?

[nhomar]

FWIW, for our own CI needs, we created a script dedicated to checking odoo logs, with agressive defaults (WARNING level records are considered errors) and a regex-based mechanism to filter expected errors.

@sbidoul that's more or less what we do internally hacking a little mqt itself.

@moylop260 is this PR valid to be merged as it is? I am worried of change the level and bring false green/red on this.

I prefer move this to a future version, What do you think?

[lasley]

Hi @JesusZapata & @moylop260 - any update on this?