Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] fieldservice #740

Merged
merged 229 commits into from
Mar 17, 2021
Merged

[14.0][MIG] fieldservice #740

merged 229 commits into from
Mar 17, 2021

Conversation

hparfr
Copy link
Contributor

@hparfr hparfr commented Mar 11, 2021

Migration of fieldservice module.

Based on 13.0.1.2.0 and including some changes discussed in issue #735

fsm.template:

  • company_id: remove default value
  • hour : rename field to duration

Replace #695 due to inactivity.

max3903 and others added 30 commits March 9, 2021 18:03
@max3903 @hparfr
[ADD] fieldservice 0.0.1 (#2)
25a9bfd
@brian10048 @hparfr
[ADD] Vehicle (OCA#23)
1d4e21d 
* [ADD] Vehicle
@hparfr
[OCA]12567 Location structure needs to reflect hierarchy of Buildings (…
0a7e990 
…#22)

* [IMP] Extend fsm.location object
@max3903 @hparfr
[FIX] View
3a5d784
@max3903 @hparfr
[ADD] location, territory, branch, district, region
03be05a
@max3903 @hparfr
[FIX] PR comments
4e776c9
@hparfr
[ADD] Boolean field in fsm.stage to indicate last stages
4fc7fff
@brian10048 @hparfr
[ADD] fieldservice_stock 0.0.1
ba9e67a
@jesulo @hparfr
Update fsm.wizard
0bef3b4
@hparfr
[IMP] timeline view
c552fad
@hparfr
[IMP] timeline view
9d4a692
@hparfr
[IMP] Add geoengine view on fsm.order
b221261
@max3903 @hparfr
[FIX] PEP8 errors
112bdd2
@hparfr
[ADD] FSM Person, FSM Location, location_hierarchy
4961505
@max3903 @hparfr
[FIX] sales_territory_id
b7cf622
@max3903 @hparfr
[FIX] category
fbb3e60
@max3903 @hparfr
[FIX] Missing field
1e4fc25
@max3903 @hparfr
[IMP] View
c95f54a
@max3903 @hparfr
[FIX] config and menu
c61d50a
@max3903 @hparfr
[IMP] Add option to install fieldservice_distribution
1f8dc59
@max3903 @hparfr
[FIX] Typo
d9969fd
@max3903 @hparfr
[IMP] Add working schedule on the fsm.person
1b7ccfe
@max3903 @hparfr
[FIX] Missing dependency
97f8d33
@max3903 @hparfr
[IMP] Add fsm.route reporting views
a0242ab
@max3903 @hparfr
[IMP] Add fsm.vehicle reporting views
b1f2c9f
@max3903 @hparfr
[IMP] Add fsm.equipment kanban and reporting views
efa8d34
@max3903 @hparfr
[IMP] Add Config / Persons menu item
713b5d2
@max3903 @hparfr
[IMP] Various improvements
c5c412d
@hparfr
[ADD] fieldservice_skill
35d5ba8
@osimallen @hparfr
[IMP] Enable geometry on location
fa416d1
@brian10048 brian10048 added this to the 14.0 milestone Mar 11, 2021
@brian10048 brian10048 linked an issue Mar 11, 2021 that may be closed by this pull request
Migration to version 14.0 #646
Open
43 tasks
@brian10048
Copy link
Contributor

Code review comments made.

Overall looks good and thank you for finding some gaps that were missed in v13 migration

marcelsavegnago
marcelsavegnago approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bodedra
bodedra approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic FSM tested in runbot. LGTM.

  • Create Order types
  • Create FSM Category
  • Create FSM Tags
  • Create FSM order and check Schedule Details.
  • Print "Service Order" report.
  • Reporting - Orders and Locations
  • Dashboard

Nice work and contribution.

@brian10048
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-740-by-brian10048-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7f06f86 into OCA:14.0 Mar 17, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6ccb45c. Thanks a lot for contributing to OCA. ❤️

@brian10048 brian10048 mentioned this pull request Mar 17, 2021
Closed
@hparfr hparfr mentioned this pull request Mar 25, 2021
Closed
9 tasks
@hparfr hparfr deleted the 14.0-mig-fieldservice-wrong branch April 13, 2021 14:38
@brian10048 brian10048 mentioned this pull request May 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourad-ehm mourad-ehm mourad-ehm left review comments

@brian10048 brian10048 brian10048 approved these changes

@bodedra bodedra bodedra approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@max3903 max3903 Awaiting requested review from max3903

@dreispt dreispt Awaiting requested review from dreispt

@osi-scampbell osi-scampbell Awaiting requested review from osi-scampbell

@RLeeOSI RLeeOSI Awaiting requested review from RLeeOSI

Assignees

@hparfr hparfr

Labels
approved merged 🎉 migration
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.

Migration to version 14.0