Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] sale_crm_event_reservation: Migration to version 17.0 #425

Open
wants to merge 14 commits into
base: 17.0
Choose a base branch
from

Conversation

pilarvargas-tecnativa
Copy link

@pilarvargas-tecnativa pilarvargas-tecnativa commented Jan 14, 2025

Jairo Llopis and others added 13 commits January 14, 2025 13:10
This module extends the functionality of *crm_event*, *event_sale_reservation*
and *sale_crm* to support fast generation of event quotations from
opportunities and to allow you to sell events like a boss.

@Tecnativa TT27664

[UPD] Update sale_crm_event_reservation.pot

[UPD] README.rst
For complying with manifestoo requirements.
Currently translated at 100.0% (26 of 26 strings)

Translation: event-15.0/event-15.0-sale_crm_event_reservation
Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-sale_crm_event_reservation/it/
Currently translated at 100.0% (26 of 26 strings)

Translation: event-15.0/event-15.0-sale_crm_event_reservation
Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-sale_crm_event_reservation/es/
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 17.0-mig-sale_crm_event_reservation branch from 84838a4 to 0650502 Compare January 14, 2025 12:11
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

Thanks :)

Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor change: to prevent issues in countries where the time zone is negative, it's better to use context_today to ensure the date is returned in the user's local time zone.

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 17.0-mig-sale_crm_event_reservation branch from 0650502 to 1470515 Compare January 15, 2025 16:56
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pedrobaeza
Copy link
Member

/ocabot migration sale_crm_event_reservation
/ocabot merge nobump

@api.depends("mode")
def _compute_allowed_event_ids(self):
for record in self:
events = self.env["event.event"].search(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm quite doubtful on this...

for record in self:
record.allowed_event_ticket_ids = []
if record.event_id:
tickets = self.env["event.event.ticket"].search(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants