-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] sale_crm_event_reservation: Migration to version 17.0 #425
base: 17.0
Are you sure you want to change the base?
[17.0][MIG] sale_crm_event_reservation: Migration to version 17.0 #425
Conversation
This module extends the functionality of *crm_event*, *event_sale_reservation* and *sale_crm* to support fast generation of event quotations from opportunities and to allow you to sell events like a boss. @Tecnativa TT27664 [UPD] Update sale_crm_event_reservation.pot [UPD] README.rst
For complying with manifestoo requirements.
Currently translated at 100.0% (26 of 26 strings) Translation: event-15.0/event-15.0-sale_crm_event_reservation Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-sale_crm_event_reservation/it/
Currently translated at 100.0% (26 of 26 strings) Translation: event-15.0/event-15.0-sale_crm_event_reservation Translate-URL: https://translation.odoo-community.org/projects/event-15-0/event-15-0-sale_crm_event_reservation/es/
84838a4
to
0650502
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 👍
Thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a minor change: to prevent issues in countries where the time zone is negative, it's better to use context_today
to ensure the date is returned in the user's local time zone.
sale_crm_event_reservation/wizards/crm_lead_event_sale_wizard.py
Outdated
Show resolved
Hide resolved
sale_crm_event_reservation/wizards/crm_lead_event_sale_wizard.py
Outdated
Show resolved
Hide resolved
0650502
to
1470515
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/ocabot migration sale_crm_event_reservation |
@api.depends("mode") | ||
def _compute_allowed_event_ids(self): | ||
for record in self: | ||
events = self.env["event.event"].search( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm quite doubtful on this...
for record in self: | ||
record.allowed_event_ticket_ids = [] | ||
if record.event_id: | ||
tickets = self.env["event.event.ticket"].search( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
cc @Tecnativa TT51941
@chienandalu @carlos-lopez-tecnativa please review