Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] event_stage_cancelled: New module #363

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

chienandalu
Copy link
Member

Up to v14, events had an state field instead of configurable stages. A lost feature with that change was the concept of a cancelled event and with it the logic associated to it: when we cancelled an event, its registrations were cancelled along with it.

@Tecnativa TT47686

please review @pedrobaeza

@pedrobaeza pedrobaeza added this to the 15.0 milestone Feb 9, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put the flag is_cancelled in event.event_stage_cancelled as data of the module.

event_stage_cancelled/__manifest__.py Outdated Show resolved Hide resolved
event_stage_cancelled/readme/DESCRIPTION.md Outdated Show resolved Hide resolved
@chienandalu chienandalu force-pushed the 15.0-add-event_stage_cancelled branch from 9fdb484 to bab137a Compare February 12, 2024 08:28
@chienandalu chienandalu force-pushed the 15.0-add-event_stage_cancelled branch from bab137a to 9d6c120 Compare February 12, 2024 08:32
@chienandalu
Copy link
Member Author

All done 😄

@pedrobaeza
Copy link
Member

Please include in the README the new features.

@chienandalu chienandalu force-pushed the 15.0-add-event_stage_cancelled branch from 208c018 to 7319286 Compare February 16, 2024 07:57
@pedrobaeza
Copy link
Member

On runboat, I have cancelled an event (http://oca-event-15-0-pr363-73192864b7ce.runboat.odoo-community.org/web#id=8&cids=1&menu_id=134&action=204&model=event.event&view_type=form), defining a mail action, but no mail was sent.

And another thing: we need a cancel mail template.

@chienandalu chienandalu force-pushed the 15.0-add-event_stage_cancelled branch from 7319286 to 467cec7 Compare February 16, 2024 09:23
@chienandalu
Copy link
Member Author

On runboat, I have cancelled an event (http://oca-event-15-0-pr363-73192864b7ce.runboat.odoo-community.org/web#id=8&cids=1&menu_id=134&action=204&model=event.event&view_type=form), defining a mail action, but no mail was sent.

Did you run the cron? It's the one in charge of handling the schedulers. And after the scheduler is settled you should force the outgoing mail queue.

Anyway, I just improved the reliability as I was seeing when doing the test cases some pitfalls.

And another thing: we need a cancel mail template.

👍

@chienandalu chienandalu force-pushed the 15.0-add-event_stage_cancelled branch 2 times, most recently from 0cd492a to 5af3d44 Compare February 16, 2024 09:58
@chienandalu
Copy link
Member Author

Ready to test

@pedrobaeza
Copy link
Member

I don't get the mails to work. I have run manually "Event Email Reminder" cron also. The event is http://oca-event-15-0-pr363-5af3d44b1b5e.runboat.odoo-community.org/web#id=8&cids=1&menu_id=134&action=204&model=event.event&view_type=form

@chienandalu chienandalu force-pushed the 15.0-add-event_stage_cancelled branch from 5af3d44 to cc748ba Compare February 19, 2024 08:35
@chienandalu
Copy link
Member Author

I don't get the mails to work...

Ok, it's just an incompatibility issue with event_registration_cancel_reason. I just added a flagged context to avoid it. A compatibility module might be needed but we don't have any customer making use of these two at once.

@pedrobaeza pedrobaeza requested a review from victoralmau March 26, 2024 18:11
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-363-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 844eca5 into OCA:15.0 Mar 27, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 744cfaa. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-add-event_stage_cancelled branch March 27, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants