-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][ADD] event_stage_cancelled: New module #363
[15.0][ADD] event_stage_cancelled: New module #363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put the flag is_cancelled
in event.event_stage_cancelled
as data of the module.
9fdb484
to
bab137a
Compare
bab137a
to
9d6c120
Compare
All done 😄 |
Please include in the README the new features. |
208c018
to
7319286
Compare
On runboat, I have cancelled an event (http://oca-event-15-0-pr363-73192864b7ce.runboat.odoo-community.org/web#id=8&cids=1&menu_id=134&action=204&model=event.event&view_type=form), defining a mail action, but no mail was sent. And another thing: we need a cancel mail template. |
7319286
to
467cec7
Compare
Did you run the cron? It's the one in charge of handling the schedulers. And after the scheduler is settled you should force the outgoing mail queue. Anyway, I just improved the reliability as I was seeing when doing the test cases some pitfalls.
👍 |
0cd492a
to
5af3d44
Compare
Ready to test |
I don't get the mails to work. I have run manually "Event Email Reminder" cron also. The event is http://oca-event-15-0-pr363-5af3d44b1b5e.runboat.odoo-community.org/web#id=8&cids=1&menu_id=134&action=204&model=event.event&view_type=form |
5af3d44
to
cc748ba
Compare
Ok, it's just an incompatibility issue with |
cc748ba
to
502d8dd
Compare
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 744cfaa. Thanks a lot for contributing to OCA. ❤️ |
Up to v14, events had an state field instead of configurable stages. A lost feature with that change was the concept of a cancelled event and with it the logic associated to it: when we cancelled an event, its registrations were cancelled along with it.
@Tecnativa TT47686
please review @pedrobaeza