[REF][ADD] partner_invoicing_mode_cash_on_delivery

The aim was to extract logic that depends on shipment_advice to have a separate
module to manage cash on delivery process independently.

shipment_advice_cash_on_delivery/README.rst → partner_invoicing_mode_cash_on_delivery/README.rst

@@ -1,13 +1,13 @@
-================================
-Shipment Advice Cash on Delivery
-================================
+=======================================
+Partner Invoicing Mode Cash on Delivery
+=======================================
 
 .. 
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! source digest: sha256:402231bc491adcd94e5edba386548075cb5aa8332caa2ca5843f7bea5ba88f0f
+   !! source digest: sha256:5525b56e6241690abaa44bb465f180508ee6a0af871cd8a3d2232216e25c602c
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
@@ -16,22 +16,22 @@ Shipment Advice Cash on Delivery
 .. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
-.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fstock--logistics--transport-lightgray.png?logo=github
-    :target: https://github.com/OCA/stock-logistics-transport/tree/16.0/shipment_advice_cash_on_delivery
-    :alt: OCA/stock-logistics-transport
+.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Faccount--invoicing-lightgray.png?logo=github
+    :target: https://github.com/OCA/account-invoicing/tree/16.0/partner_invoicing_mode_cash_on_delivery
+    :alt: OCA/account-invoicing
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/stock-logistics-transport-16-0/stock-logistics-transport-16-0-shipment_advice_cash_on_delivery
+    :target: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode_cash_on_delivery
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-transport&target_branch=16.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/account-invoicing&target_branch=16.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
 
 Allow to mark a payment mode as "cash on delivery".
 When the picking is delivered, an invoice is automaticaly generated with the
 amount to be paid.
-Allows users to print cash on delivery invoices from a shipment advice
+Allows users to identify cash on delivery invoices on shippings.
 
 **Table of contents**
 
@@ -41,15 +41,16 @@ Allows users to print cash on delivery invoices from a shipment advice
 Configuration
 =============
 
-You must mark a payment mode as "cash on delivery".
+You must mark a payment mode as "cash on delivery". If you want the invoice
+to be posted at the same moment, check the "Auto validate Invoice When Cash On Delivery"
 
 Bug Tracker
 ===========
 
-Bugs are tracked on `GitHub Issues <https://github.com/OCA/stock-logistics-transport/issues>`_.
+Bugs are tracked on `GitHub Issues <https://github.com/OCA/account-invoicing/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/stock-logistics-transport/issues/new?body=module:%20shipment_advice_cash_on_delivery%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/account-invoicing/issues/new?body=module:%20partner_invoicing_mode_cash_on_delivery%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -69,6 +70,7 @@ Contributors
 * Jacques-Etienne Baudoux <[email protected]>
 * Souheil Bejaoui <[email protected]>
 * Tuan Tran <[email protected]>
+* Denis Roussel <[email protected]>
 
 Maintainers
 ~~~~~~~~~~~
@@ -83,6 +85,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/stock-logistics-transport <https://github.com/OCA/stock-logistics-transport/tree/16.0/shipment_advice_cash_on_delivery>`_ project on GitHub.
+This module is part of the `OCA/account-invoicing <https://github.com/OCA/account-invoicing/tree/16.0/partner_invoicing_mode_cash_on_delivery>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

shipment_advice_cash_on_delivery/__manifest__.py → partner_invoicing_mode_cash_on_delivery/__manifest__.py

@@ -4,21 +4,19 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
 {
-    "name": "Shipment Advice Cash on Delivery",
-    "summary": """This module allows users to print cash on delivery invoices
-    from a shipment advice""",
+    "name": "Partner Invoicing Mode Cash on Delivery",
+    "summary": """This module allows users to distinguish cash on delivery invoices
+    in the automatic invoicing flow""",
     "version": "16.0.1.0.0",
     "license": "AGPL-3",
     "author": "BCIM, ACSONE SA/NV, Camptocamp, Odoo Community Association (OCA)",
-    "website": "https://github.com/OCA/stock-logistics-transport",
+    "website": "https://github.com/OCA/account-invoicing",
     "depends": [
         "account_payment_sale",
-        "shipment_advice",
         "partner_invoicing_mode_at_shipping",
     ],
     "data": [
         "views/account_payment_mode_views.xml",
-        "views/shipment_advice.xml",
         "views/stock_picking_views.xml",
     ],
 }

shipment_advice_cash_on_delivery/models/__init__.py → partner_invoicing_mode_cash_on_delivery/models/__init__.py

@@ -1,3 +1,2 @@
 from . import account_payment_mode
-from . import shipment_advice
 from . import stock_picking

partner_invoicing_mode_cash_on_delivery/models/account_payment_mode.py

@@ -0,0 +1,15 @@
+# Copyright 2018 Jacques-Etienne Baudoux (BCIM) <[email protected]>
+
+from odoo import fields, models
+
+
+class AccountPaymentMode(models.Model):
+    _inherit = "account.payment.mode"
+
+    cash_on_delivery = fields.Boolean(
+        help="Check this if you want to identify Cash On Delivery invoices on stock pickings."
+    )
+    auto_validate_invoice_cash_on_delivery = fields.Boolean(
+        help="Check this if you want Cash on Delivery deliveries will validate "
+        "automatically generated invoices."
+    )

shipment_advice_cash_on_delivery/models/stock_picking.py → partner_invoicing_mode_cash_on_delivery/models/stock_picking.py

@@ -14,6 +14,11 @@ class StockPicking(models.Model):
     )
 
     def _invoice_at_shipping(self):
+        """
+        This will take this picking into account for invoice creation (at shipping)
+        when sale order has Cash On Delivery set and even if the partner is not
+        using that mode (at shipping).
+        """
         self.ensure_one()
         res = super()._invoice_at_shipping()
         res = res or self.sale_id.payment_mode_id.cash_on_delivery

partner_invoicing_mode_cash_on_delivery/readme/CONFIGURE.rst

@@ -0,0 +1,2 @@
+You must mark a payment mode as "cash on delivery". If you want the invoice
+to be posted at the same moment, check the "Auto validate Invoice When Cash On Delivery"

shipment_advice_cash_on_delivery/readme/CONTRIBUTORS.rst → partner_invoicing_mode_cash_on_delivery/readme/CONTRIBUTORS.rst

@@ -1,3 +1,4 @@
 * Jacques-Etienne Baudoux <[email protected]>
 * Souheil Bejaoui <[email protected]>
 * Tuan Tran <[email protected]>
+* Denis Roussel <[email protected]>

shipment_advice_cash_on_delivery/readme/DESCRIPTION.rst → partner_invoicing_mode_cash_on_delivery/readme/DESCRIPTION.rst

@@ -1,4 +1,4 @@
 Allow to mark a payment mode as "cash on delivery".
 When the picking is delivered, an invoice is automaticaly generated with the
 amount to be paid.
-Allows users to print cash on delivery invoices from a shipment advice
+Allows users to identify cash on delivery invoices on shippings.

shipment_advice_cash_on_delivery/static/description/index.html → partner_invoicing_mode_cash_on_delivery/static/description/index.html

@@ -1,20 +1,20 @@
+<?xml version="1.0" encoding="utf-8" ?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
-<meta name="generator" content="Docutilsrc1: https://docutils.sourceforge.io/" />
-<title>Shipment Advice Cash on Delivery</title>
+<meta name="generator" content="Docutils: http://docutils.sourceforge.net/" />
+<title>Partner Invoicing Mode Cash on Delivery</title>
 <style type="text/css">
 
 /*
 :Author: David Goodger ([email protected])
-:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
+:Id: $Id: html4css1.css 7952 2016-07-26 18:15:59Z milde $
 :Copyright: This stylesheet has been placed in the public domain.
 
 Default cascading style sheet for the HTML output of Docutils.
-Despite the name, some widely supported CSS2 features are used.
 
-See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
+See http://docutils.sf.net/docs/howto/html-stylesheets.html for how to
 customize this style sheet.
 */
 
@@ -275,7 +275,7 @@
   margin-left: 2em ;
   margin-right: 2em }
 
-pre.code .ln { color: gray; } /* line numbers */
+pre.code .ln { color: grey; } /* line numbers */
 pre.code, code { background-color: #eeeeee }
 pre.code .comment, code .comment { color: #5C6576 }
 pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -301,7 +301,7 @@
 span.pre {
   white-space: pre }
 
-span.problematic, pre.problematic {
+span.problematic {
   color: red }
 
 span.section-subtitle {
@@ -360,73 +360,73 @@
 </style>
 </head>
 <body>
-<div class="document" id="shipment-advice-cash-on-delivery">
-<h1 class="title">Shipment Advice Cash on Delivery</h1>
+<div class="document" id="partner-invoicing-mode-cash-on-delivery">
+<h1 class="title">Partner Invoicing Mode Cash on Delivery</h1>
 
 <!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! source digest: sha256:402231bc491adcd94e5edba386548075cb5aa8332caa2ca5843f7bea5ba88f0f
+!! source digest: sha256:5525b56e6241690abaa44bb465f180508ee6a0af871cd8a3d2232216e25c602c
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/stock-logistics-transport/tree/16.0/shipment_advice_cash_on_delivery"><img alt="OCA/stock-logistics-transport" src="https://img.shields.io/badge/github-OCA%2Fstock--logistics--transport-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/stock-logistics-transport-16-0/stock-logistics-transport-16-0-shipment_advice_cash_on_delivery"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-transport&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/OCA/account-invoicing/tree/16.0/partner_invoicing_mode_cash_on_delivery"><img alt="OCA/account-invoicing" src="https://img.shields.io/badge/github-OCA%2Faccount--invoicing-lightgray.png?logo=github" /></a> <a class="reference external" href="https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-partner_invoicing_mode_cash_on_delivery"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external" href="https://runboat.odoo-community.org/builds?repo=OCA/account-invoicing&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>Allow to mark a payment mode as “cash on delivery”.
 When the picking is delivered, an invoice is automaticaly generated with the
 amount to be paid.
-Allows users to print cash on delivery invoices from a shipment advice</p>
+Allows users to identify cash on delivery invoices on shippings.</p>
 <p><strong>Table of contents</strong></p>
 <div class="contents local topic" id="contents">
 <ul class="simple">
-<li><a class="reference internal" href="#configuration" id="toc-entry-1">Configuration</a></li>
-<li><a class="reference internal" href="#bug-tracker" id="toc-entry-2">Bug Tracker</a></li>
-<li><a class="reference internal" href="#credits" id="toc-entry-3">Credits</a><ul>
-<li><a class="reference internal" href="#authors" id="toc-entry-4">Authors</a></li>
-<li><a class="reference internal" href="#contributors" id="toc-entry-5">Contributors</a></li>
-<li><a class="reference internal" href="#maintainers" id="toc-entry-6">Maintainers</a></li>
+<li><a class="reference internal" href="#configuration" id="id1">Configuration</a></li>
+<li><a class="reference internal" href="#bug-tracker" id="id2">Bug Tracker</a></li>
+<li><a class="reference internal" href="#credits" id="id3">Credits</a><ul>
+<li><a class="reference internal" href="#authors" id="id4">Authors</a></li>
+<li><a class="reference internal" href="#contributors" id="id5">Contributors</a></li>
+<li><a class="reference internal" href="#maintainers" id="id6">Maintainers</a></li>
 </ul>
 </li>
 </ul>
 </div>
 <div class="section" id="configuration">
-<h1><a class="toc-backref" href="#toc-entry-1">Configuration</a></h1>
-<p>You must mark a payment mode as “cash on delivery”.</p>
+<h1><a class="toc-backref" href="#id1">Configuration</a></h1>
+<p>You must mark a payment mode as “cash on delivery”. If you want the invoice
+to be posted at the same moment, check the “Auto validate Invoice When Cash On Delivery”</p>
 </div>
 <div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h1>
-<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/stock-logistics-transport/issues">GitHub Issues</a>.
+<h1><a class="toc-backref" href="#id2">Bug Tracker</a></h1>
+<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/account-invoicing/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/stock-logistics-transport/issues/new?body=module:%20shipment_advice_cash_on_delivery%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/account-invoicing/issues/new?body=module:%20partner_invoicing_mode_cash_on_delivery%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
-<h1><a class="toc-backref" href="#toc-entry-3">Credits</a></h1>
+<h1><a class="toc-backref" href="#id3">Credits</a></h1>
 <div class="section" id="authors">
-<h2><a class="toc-backref" href="#toc-entry-4">Authors</a></h2>
+<h2><a class="toc-backref" href="#id4">Authors</a></h2>
 <ul class="simple">
 <li>BCIM</li>
 <li>ACSONE SA/NV</li>
 <li>Camptocamp</li>
 </ul>
 </div>
 <div class="section" id="contributors">
-<h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
+<h2><a class="toc-backref" href="#id5">Contributors</a></h2>
 <ul class="simple">
 <li>Jacques-Etienne Baudoux &lt;<a class="reference external" href="mailto:je&#64;bcim.be">je&#64;bcim.be</a>&gt;</li>
 <li>Souheil Bejaoui &lt;<a class="reference external" href="mailto:souheil.bejaoui&#64;acsone.eu">souheil.bejaoui&#64;acsone.eu</a>&gt;</li>
 <li>Tuan Tran &lt;<a class="reference external" href="mailto:anhtuan&#64;trobz.com">anhtuan&#64;trobz.com</a>&gt;</li>
+<li>Denis Roussel &lt;<a class="reference external" href="mailto:denis.roussel&#64;acsone.eu">denis.roussel&#64;acsone.eu</a>&gt;</li>
 </ul>
 </div>
 <div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
+<h2><a class="toc-backref" href="#id6">Maintainers</a></h2>
 <p>This module is maintained by the OCA.</p>
-<a class="reference external image-reference" href="https://odoo-community.org">
-<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
-</a>
+<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/stock-logistics-transport/tree/16.0/shipment_advice_cash_on_delivery">OCA/stock-logistics-transport</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/account-invoicing/tree/16.0/partner_invoicing_mode_cash_on_delivery">OCA/account-invoicing</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>