Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] stock_analytic: Migration to 18.0 #710

Open
wants to merge 61 commits into
base: 18.0
Choose a base branch
from

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Nov 20, 2024

Hanane ELKHAL and others added 30 commits November 20, 2024 10:27
… Stock analytic XML part is now migrated

Add logo for generic modules
- migration point, put all the modules to not installable
This module allows the user to generate analytic information from stock
moves.

- Fixed flake8 and pylint errors.
Remove sale and purchase dependency. Add test

Only assign analytic account if account != valuation acc

Changing field name account_analytic_id

Adjust to OCA latest guidelines. Add some usahe info on README
Remove remaining encoding hints.
Correct lint in test
Correct flake8 in test
Fix documentation and test_flake8
Currently translated at 100.0% (2 of 2 strings)

Translation: account-analytic-11.0/account-analytic-11.0-stock_analytic
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-11-0/account-analytic-11-0-stock_analytic/de/
Currently translated at 100.0% (2 of 2 strings)

Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/pt_BR/
Currently translated at 100.0% (2 of 2 strings)

Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/ca/
Currently translated at 100.0% (3 of 3 strings)

Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/hr/
Currently translated at 100.0% (4 of 4 strings)

Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/de/
Currently translated at 100.0% (4 of 4 strings)

Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/pt/
Currently translated at 100.0% (4 of 4 strings)

Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic
Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/es/
(cherry picked from commit 9255622)
aisopuro and others added 3 commits November 20, 2024 10:27
This commit fixes analytic_distribution not being passed from move to move line when updated after the move line is created.
@peluko00 peluko00 mentioned this pull request Nov 20, 2024
10 tasks
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@houssine78
Copy link

@pedrobaeza this PR can be merged. thanks !

@dreispt
Copy link
Member

dreispt commented Dec 1, 2024

/ocabot migration stock_analytic
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Dec 1, 2024
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-710-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 1, 2024
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-710-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@gbrito
Copy link

gbrito commented Jan 10, 2025

@dreispt is there anything we can do to merge this?

Copy link

@gbrito gbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peluko00 Can you please push this changes?

stock_analytic/tests/test_stock_picking.py Outdated Show resolved Hide resolved
stock_analytic/tests/test_stock_picking.py Outdated Show resolved Hide resolved
stock_analytic/tests/test_stock_picking.py Outdated Show resolved Hide resolved
@peluko00 peluko00 force-pushed the 18.0-mig-stock_analytic branch from fff262e to dc2ca0a Compare January 13, 2025 08:36
@peluko00
Copy link
Contributor Author

peluko00 commented Jan 13, 2025

@dreispt is there anything we can do to merge this?

Done, thanks!

@dreispt seems it's ready to merge

@gbrito
Copy link

gbrito commented Jan 13, 2025

@peluko00 thanks, good work

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.