[17.0][MIG] account_analytic_distribution_manual: Migration to 17.0 #700

BernatObrador · 2024-10-10T12:07:16Z

Module migrated to version 17.0

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review

BernatObrador · 2024-10-18T07:46:55Z

I hope you're doing well! I’m facing some issues with the tests as they’re failing due to the tour, and I'm not sure how to resolve it. If you could lend a hand, I would really appreciate it!

Thank you in advance!

pedrobaeza · 2024-10-18T18:54:41Z

Not sure. We had a similar problem some weeks ago that was solved with this: OCA/oca-ci#78

@sbidoul @chienandalu do you have any clue?

BernatObrador · 2024-10-19T11:01:31Z

Thanks, @pedrobaeza! If there's anything I can assist with, just let me know.

chienandalu

You need to change the tour first

...lytic_distribution_manual/static/src/tests/tours/account_analytic_distribution_manual.esm.js

BernatObrador · 2024-11-07T09:17:04Z

Hi @chienandalu! Thank you very much for your contribution! The changes have been applied, but now the tour fails at the step "Create new invoice" with the trigger .o_list_button_add.

I'll take a closer look at this and see if I can resolve it. Thanks again for your help!

chienandalu · 2024-11-07T09:19:29Z

Yes, now it's just a matter of debugging the steps 😉

BernatObrador · 2024-12-11T12:20:06Z

The tour tests are now working correctly. The issue lies with the tests themselves. I’m not sure why, but when running the tour directly through Odoo, everything works fine: analytic entries are generated as expected, and the other tests also pass without issues. However, when running Odoo tests that include the tour, it fails because it's not generating the analytic as intended. Do yo have any clue about why this can happen? Thanks in advance! @pedrobaeza @chienandalu

pedrobaeza · 2024-12-11T12:22:28Z

Maybe @carlos-lopez-tecnativa can say.

ppyczko

LGTM, tested in runboat and code review 👍

BernatObrador · 2024-12-19T19:01:28Z

@carlos-lopez-tecnativa Thanks a lot for your time and valuable feedback! The bugs have been fixed. Could you please take another look and review the changes?

carlos-lopez-tecnativa · 2024-12-23T20:06:37Z

@carlos-lopez-tecnativa Thanks a lot for your time and valuable feedback! The bugs have been fixed. Could you please take another look and review the changes?

I tested again, but the issues are still present. Could you review it once more? I’m not sure if network latency on Runboat could be related.

2024-12-23.15-02-42.mp4

BernatObrador · 2024-12-24T06:48:43Z

Grabación de pantalla desde 2024-12-24 07-43-43.webm
It's working fine when I try it on Runboat, and my team tested it as well without any issues. One person did encounter a similar problem, but they resolved it by using an incognito tab. Could you please try using an incognito tab as well? It might be related to cookies or cached data causing the issue.

...distribution_manual/static/src/components/analytic_distribution/analytic_distribution.esm.js

BernatObrador · 2024-12-27T07:38:18Z

@carlos-lopez-tecnativa Can you review again? Thanks for your time!

carlos-lopez-tecnativa

Tested and working fine. Please squash administrative commits(see https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests). Thanks for the effort in the migration.

…complete analytic accounts on any model that has a field for analytic accounts.

Currently translated at 95.6% (22 of 23 strings) Translation: account-analytic-16.0/account-analytic-16.0-account_analytic_distribution_manual Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-account_analytic_distribution_manual/es/

…tics account from manual distribution - Show the current distribution selected at the top of the tags - When unselecting a distribution, all related analytic accounts are also unselected

… old data to new models(if table exists)

Currently translated at 100.0% (26 of 26 strings) Translation: account-analytic-16.0/account-analytic-16.0-account_analytic_distribution_manual Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-account_analytic_distribution_manual/it/

…teger to many2one - If the user needs to group by this field, it was impossible when it was an integer. - Added a script to populate the new field in models related to account_analytic_tags. Note: When multiple tags are present, only the last record is populated.

Currently translated at 100.0% (26 of 26 strings) Translation: account-analytic-16.0/account-analytic-16.0-account_analytic_distribution_manual Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-account_analytic_distribution_manual/it/

…tion_id into account.invoice.report

Currently translated at 100.0% (27 of 27 strings) Translation: account-analytic-16.0/account-analytic-16.0-account_analytic_distribution_manual Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-account_analytic_distribution_manual/it/

…export/import of analytical distributions TT50235

Currently translated at 100.0% (29 of 29 strings) Translation: account-analytic-16.0/account-analytic-16.0-account_analytic_distribution_manual Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-account_analytic_distribution_manual/it/

…d field to analytic items TT50751

Currently translated at 75.0% (24 of 32 strings) Translation: account-analytic-16.0/account-analytic-16.0-account_analytic_distribution_manual Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-account_analytic_distribution_manual/es/

Currently translated at 100.0% (32 of 32 strings) Translation: account-analytic-16.0/account-analytic-16.0-account_analytic_distribution_manual Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-account_analytic_distribution_manual/it/

…export/import to analytic.mixin Move the functionality to the analytic.mixin model so that it can also be used in account.move.line records TT50944

BernatObrador · 2025-01-08T07:12:57Z

@carlos-lopez-tecnativa Done!

carlos-lopez-tecnativa

Could you review this use case? It’s not working as expected

carlos-lopez-tecnativa · 2025-01-08T11:40:21Z

...distribution_manual/static/src/components/analytic_distribution/analytic_distribution.esm.js

+        // When record is created, and manual_distribution_id is cleared
+        // but user discard changes, we need to refresh the manual distribution
+        const force_refresh_discart = new_manual_distribution_id === 0 && record_id > 0;
+        if (
+            manual_distribution_Changed &&
+            (new_manual_distribution_id > 0 || force_refresh_discart)
+        ) {
+            await this.refreshManualDistribution(new_manual_distribution_id);
+        }


Create an invoice, add a manual distribution, and save.

Edit the invoice and remove the manual distribution.

Focus on another element.

Discard the changes.

Issue: The manual distribution is not displayed; it’s lost after discarding the changes

V17

V17.account_analytic_distribution_manual.mp4

V16

V16.account_analytic_distribution_manual.mp4

The issue lies in the fact that the method willUpdate(nextProps) has been replaced with willUpdateRecord(record).

The challenge is that I can no longer determine whether force_refresh_discart should be applied, as this.props no longer includes this.props.record.data.id. This makes it impossible to track whether the user is discarding changes.

Do you have any suggestions on how to resolve this? I specifically need a reliable way to detect when the user discards changes so that I can apply the correct distribution.

BernatObrador force-pushed the 17.0-mig-account_analytic_distribution_manual branch from 5febd1f to 5ddf248 Compare October 11, 2024 11:40

BernatObrador mentioned this pull request Oct 15, 2024

Migration to version 17.0 #607

Open

18 tasks

BernatObrador force-pushed the 17.0-mig-account_analytic_distribution_manual branch 6 times, most recently from 527842e to 4a11424 Compare October 18, 2024 06:11

BernatObrador mentioned this pull request Oct 22, 2024

[17.0][ADD] account_analytic_distribution_manual_date: New module account_analytic_distribution_manual_date #702

Open

BernatObrador marked this pull request as ready for review November 7, 2024 07:54

BernatObrador force-pushed the 17.0-mig-account_analytic_distribution_manual branch from 4a11424 to ef9c240 Compare November 7, 2024 08:01

chienandalu suggested changes Nov 7, 2024

View reviewed changes

...lytic_distribution_manual/static/src/tests/tours/account_analytic_distribution_manual.esm.js Outdated Show resolved Hide resolved

...lytic_distribution_manual/static/src/tests/tours/account_analytic_distribution_manual.esm.js Outdated Show resolved Hide resolved

BernatObrador force-pushed the 17.0-mig-account_analytic_distribution_manual branch 2 times, most recently from be2a906 to 1c2324c Compare November 7, 2024 09:06

BernatObrador force-pushed the 17.0-mig-account_analytic_distribution_manual branch from 1c2324c to f87beaa Compare November 7, 2024 10:29

BernatObrador marked this pull request as draft November 7, 2024 10:29

BernatObrador force-pushed the 17.0-mig-account_analytic_distribution_manual branch from f87beaa to 379c043 Compare November 7, 2024 10:37

BernatObrador force-pushed the 17.0-mig-account_analytic_distribution_manual branch 2 times, most recently from 158bf67 to e90815d Compare November 22, 2024 09:29

BernatObrador force-pushed the 17.0-mig-account_analytic_distribution_manual branch from e90815d to 6e9004d Compare December 10, 2024 12:19

BernatObrador force-pushed the 17.0-mig-account_analytic_distribution_manual branch from 6e9004d to 91623fe Compare December 17, 2024 12:08

BernatObrador marked this pull request as ready for review December 17, 2024 12:14

ppyczko approved these changes Dec 18, 2024

View reviewed changes

BernatObrador force-pushed the 17.0-mig-account_analytic_distribution_manual branch 2 times, most recently from 501221c to f020273 Compare December 19, 2024 18:54

carlos-lopez-tecnativa suggested changes Dec 24, 2024

View reviewed changes

...distribution_manual/static/src/components/analytic_distribution/analytic_distribution.esm.js Outdated Show resolved Hide resolved

BernatObrador force-pushed the 17.0-mig-account_analytic_distribution_manual branch from f020273 to 9e8c2aa Compare December 27, 2024 07:36

carlos-lopez-tecnativa reviewed Jan 7, 2025

View reviewed changes

carlos-lopez-tecnativa and others added 18 commits January 8, 2025 08:09

[ADD] account_analytic_distribution_manual: New module to easily auto…

690ae9b

…complete analytic accounts on any model that has a field for analytic accounts.

Added translation using Weblate (Italian)

6e41782

[IMP] account_analytic_distribution_manual: Enhanced control of analy…

958cf0b

…tics account from manual distribution - Show the current distribution selected at the top of the tags - When unselecting a distribution, all related analytic accounts are also unselected

[IMP] account_analytic_distribution_manual: post_init_hook to convert…

0081e2d

… old data to new models(if table exists)

[IMP] account_analytic_distribution_manual: add field manual_distribu…

f401c2c

…tion_id into account.invoice.report

[IMP] account_analytic_distribution_manual: Add extra json field for …

3387bc7

…export/import of analytical distributions TT50235

[IMP] account_analytic_distribution_manual: Add manual_distribution_i…

aff037a

…d field to analytic items TT50751

[IMP] account_analytic_distribution_manual: Add extra json field for …

67414c6

…export/import to analytic.mixin Move the functionality to the analytic.mixin model so that it can also be used in account.move.line records TT50944

[IMP] account_analytic_distribution_manual: pre-commit auto fixes

ade5321

[MIG] account_analytic_distribution_manual: Migration to 17.0

60f773d

BernatObrador force-pushed the 17.0-mig-account_analytic_distribution_manual branch from 9e8c2aa to 60f773d Compare January 8, 2025 07:09

carlos-lopez-tecnativa suggested changes Jan 8, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] account_analytic_distribution_manual: Migration to 17.0 #700

[17.0][MIG] account_analytic_distribution_manual: Migration to 17.0 #700

BernatObrador commented Oct 10, 2024 •

edited

Loading

BernatObrador commented Oct 18, 2024

pedrobaeza commented Oct 18, 2024

BernatObrador commented Oct 19, 2024

chienandalu left a comment

BernatObrador commented Nov 7, 2024

chienandalu commented Nov 7, 2024

BernatObrador commented Dec 11, 2024

pedrobaeza commented Dec 11, 2024

ppyczko left a comment

BernatObrador commented Dec 19, 2024

carlos-lopez-tecnativa commented Dec 23, 2024

BernatObrador commented Dec 24, 2024 •

edited

Loading

BernatObrador commented Dec 27, 2024

carlos-lopez-tecnativa left a comment •

edited

Loading

BernatObrador commented Jan 8, 2025

carlos-lopez-tecnativa left a comment

carlos-lopez-tecnativa Jan 8, 2025

BernatObrador Jan 15, 2025

[17.0][MIG] account_analytic_distribution_manual: Migration to 17.0 #700

Are you sure you want to change the base?

[17.0][MIG] account_analytic_distribution_manual: Migration to 17.0 #700

Conversation

BernatObrador commented Oct 10, 2024 • edited Loading

BernatObrador commented Oct 18, 2024

pedrobaeza commented Oct 18, 2024

BernatObrador commented Oct 19, 2024

chienandalu left a comment

Choose a reason for hiding this comment

BernatObrador commented Nov 7, 2024

chienandalu commented Nov 7, 2024

BernatObrador commented Dec 11, 2024

pedrobaeza commented Dec 11, 2024

ppyczko left a comment

Choose a reason for hiding this comment

BernatObrador commented Dec 19, 2024

carlos-lopez-tecnativa commented Dec 23, 2024

BernatObrador commented Dec 24, 2024 • edited Loading

BernatObrador commented Dec 27, 2024

carlos-lopez-tecnativa left a comment • edited Loading

Choose a reason for hiding this comment

BernatObrador commented Jan 8, 2025

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

carlos-lopez-tecnativa Jan 8, 2025

Choose a reason for hiding this comment

BernatObrador Jan 15, 2025

Choose a reason for hiding this comment

BernatObrador commented Oct 10, 2024 •

edited

Loading

BernatObrador commented Dec 24, 2024 •

edited

Loading

carlos-lopez-tecnativa left a comment •

edited

Loading