Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_analytic_organization: Added company_id field and fixed spanish translation #697

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

mpascuall
Copy link

@mpascuall mpascuall commented Oct 7, 2024

On this improvement i added the company_id field to make it work better with multi-company option and fixed spanish translation. I also inherited get_name method in order to show the organization name in the partner name.
cc https://github.com/APSL 160524

@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 @BernatObrador @ppyczko please review

Copy link
Contributor

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected in runboat and code review

@mpascuall mpascuall force-pushed the 16.0-imp-account_analytic_organization branch 2 times, most recently from da75895 to f75b62b Compare October 28, 2024 07:34
Copy link

@ppyczko ppyczko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@mpascuall
Copy link
Author

Hi @pedrobaeza! Is this ready to merge?

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 5, 2024
@pedrobaeza
Copy link
Member

Being your module, it's advisable that any of you put it as maintainer of the module, and then you will be independent to merge these fixes without depending of someone like me. Please do it and I'll merge, and from now on, you will fly alone, hehe.

@mpascuall mpascuall force-pushed the 16.0-imp-account_analytic_organization branch from f75b62b to 70213d3 Compare November 6, 2024 10:29
@mpascuall
Copy link
Author

Being your module, it's advisable that any of you put it as maintainer of the module, and then you will be independent to merge these fixes without depending of someone like me. Please do it and I'll merge, and from now on, you will fly alone, hehe.

Done! Thanks for your help :)

Copy link

@houssine78 houssine78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpascuall
Copy link
Author

mpascuall commented Dec 3, 2024

Hi @pedrobaeza, sorry for pinging you again. Could you help us to merge this pr? I put me as maintainer on this imp so after this is merge we won't need to ping you anymore.
Thank you very much in advance!

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change the year of the copyright of all files if they aren't touched. It's adding a lot of noise in the PR.

@mpascuall
Copy link
Author

Don't change the year of the copyright of all files if they aren't touched. It's adding a lot of noise in the PR.

Hi! Thanks for your comment. This module is new and it was created in 2024. It was'nt correct before, now it's fixed.

@mpascuall mpascuall force-pushed the 16.0-imp-account_analytic_organization branch 2 times, most recently from 0d27d0b to 5c75cf3 Compare December 12, 2024 06:47
@BernatObrador
Copy link
Contributor

In the Analytic Organization field of the partner form, there should be a domain that restricts the displayed organizations to those belonging to the active company. For example: ("company_id", "=", company_id). Additionally, when creating a new analytic organization, the company_id field could be prepopulated with the active company by default.

@mpascuall mpascuall force-pushed the 16.0-imp-account_analytic_organization branch from 5c75cf3 to 9df2b6d Compare January 8, 2025 11:06
@mpascuall
Copy link
Author

In the Analytic Organization field of the partner form, there should be a domain that restricts the displayed organizations to those belonging to the active company. For example: ("company_id", "=", company_id). Additionally, when creating a new analytic organization, the company_id field could be prepopulated with the active company by default.

Thanks for your feedback! Could you review again please?

@BernatObrador
Copy link
Contributor

I tested, and it's working fine. What if you add a domain at the analytic organization view that filters only by the ones of the active company?

…xed spanish translation and made organization name appear in partner name
@mpascuall mpascuall force-pushed the 16.0-imp-account_analytic_organization branch from 9df2b6d to b840ce3 Compare January 9, 2025 10:11
@mpascuall
Copy link
Author

I tested, and it's working fine. What if you add a domain at the analytic organization view that filters only by the ones of the active company?

Great idea! Done, can you try it out please?

Copy link
Contributor

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants