Add the dump command #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gegy
requested changes
Jul 1, 2023
| } | ||
| } | ||
|
|
||
| private static Path getAndCheckDataPath(Path path, Identifier identifier, String extension) { |
There was a problem hiding this comment.
Hmm, we should probably apply this to the map template exporter, too 😅
| var path = getAndCheckDataPath(generatedPath, identifier, FILE_EXTENSION); | ||
|
|
||
| var json = NbtOps.INSTANCE.convertTo(JsonOps.INSTANCE, nbt); | ||
| System.out.println(json); |
| } | ||
|
|
||
| public static CompletableFuture<Void> saveToExport(MinecraftServer server, NbtCompound nbt, Identifier identifier) { | ||
| return CompletableFuture.supplyAsync(() -> { |
There was a problem hiding this comment.
Nit: CompletableFuture.runAsync(() -> {})
Comment on lines
+44
to
+45
| try (var output = Files.newOutputStream(path)) { | ||
| var jsonWriter = new JsonWriter(new OutputStreamWriter(output, StandardCharsets.UTF_8)); |
There was a problem hiding this comment.
Suggested change
| try (var output = Files.newOutputStream(path)) { | |
| var jsonWriter = new JsonWriter(new OutputStreamWriter(output, StandardCharsets.UTF_8)); | |
| try (var writer = new JsonWriter(Files.newBufferedWriter(path, StandardCharsets.UTF_8)) { |
| jsonWriter.setIndent(" "); | ||
|
|
||
| JsonHelper.writeSorted(jsonWriter, json, DataProvider.JSON_KEY_SORTING_COMPARATOR); | ||
| jsonWriter.flush(); |
There was a problem hiding this comment.
Should not be needed if including the JsonWriter in the try-with-resources
|
|
||
| var future = DumpExporter.saveToExport(source.getServer(), nbt, identifier); | ||
|
|
||
| future.handle((v, throwable) -> { |
There was a problem hiding this comment.
whenCompleteAsync(..., server)? Sending messages off-thread has potential to explode 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a command that can be used to export entity, block entity, or command storage NBT to a file.
For example:
/dump entity 2a99a580-41d7-4c93-aa87-abd90664ff52 armor_stand/dump block 18 -60 20 chest/dump storage taters nucleoid:tater_box