-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mini-nvim: init #561
mini-nvim: init #561
Conversation
b16bd52
to
0f03d3c
Compare
I think it's best to have individual module options for each mini.nvim plugin. It's a rather rich library, and not every plugin in the suite is equally desirable. |
I agree, i'll start implementing those individually instead, and revert these changes. |
This reverts commit 952a3f1.
0f03d3c
to
9c09915
Compare
Should they all be under |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your efforts.
Two small comments to make sure we don't accidentally introduce breaking changes without asserting, or without warning the user.
On a somewhat relevant note, it might be worth adding example options for particularly complex Nix -> Lua translations at a later date. I'll keep an eye on mini suite components for options that translate weirdly. |
Thank you :) |
Resolves #538
Plugins to add:
I could also add snacks.nvim, which is a similar project, except it's all packaged as a single plugin in one call to
.setup()
Attempting to add
cursorword
, gives the following error, which is seemingly completely unrelated:Disabling
vim.debugger.nvim-dap.enable
in the config that i use for testing solves it, but i do not know excactly what causes it. Should the plugin be added anyways?Additionally, would it be preferable to document all the available options to
setupOpts
, instead of passing{}
tomkPluginSetupOption
?