Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mini-nvim: init #561

Merged
merged 49 commits into from
Jan 19, 2025
Merged

mini-nvim: init #561

merged 49 commits into from
Jan 19, 2025

Conversation

LilleAila
Copy link
Contributor

@LilleAila LilleAila commented Jan 16, 2025

Resolves #538

Plugins to add:

  • mini.ai
  • mini.align
  • mini.animate
  • mini.base16
  • mini.basics
  • mini.bracketed
  • mini.bufremove
  • mini.clue
  • mini.colors
  • mini.comment
  • mini.completion
  • mini.cursorword
    • Gives an error. TODO later
  • mini.deps
    • Won't implement, as nvf uses it's own package manager
  • mini.diff
  • mini.doc
  • mini.extra
  • mini.files
  • mini.fuzzy
  • mini.git
  • mini.hipatterns
  • mini.hues
  • mini.icons
  • mini.indentscope
  • mini.jump
  • mini.jump2d
  • mini.map
  • mini.misc
  • mini.move
  • mini.notify
  • mini.operators
  • mini.pairs
  • mini.pick
  • mini.sessions
  • mini.snippets
  • mini.splitjoin
  • mini.starter
  • mini.statusline
  • mini.surround
  • mini.tabline
  • mini.test
  • mini.trailspace
  • mini.visits

I could also add snacks.nvim, which is a similar project, except it's all packaged as a single plugin in one call to .setup()

Attempting to add cursorword, gives the following error, which is seemingly completely unrelated:

error: builder for '/nix/store/f45jbcfdgix79j40jp6gmn5rpf6s9d64-neovim-pack-dir.drv' failed with exit code 1;
       last 4 log lines:
       > created 2 symlinks in user environment
       > /nix/store/b4v1g79iv4mgrxvv0lr3h3na47j6nvgi-neovim-pack-dir/doc /build
       > Error detected while processing command line:
       > E154: Duplicate tag "before" in file /nix/store/b4v1g79iv4mgrxvv0lr3h3na47j6nvgi-neovim-pack-dir/doc/nvim-dap/dap.txt
       For full logs, run 'nix log /nix/store/f45jbcfdgix79j40jp6gmn5rpf6s9d64-neovim-pack-dir.drv'.
error: 1 dependencies of derivation '/nix/store/fnnc909qs6sahpagja83sdlj8xm0vj8l-mnw-0.10.3.drv' failed to build
error: 1 dependencies of derivation '/nix/store/djai199grxj4rf90mnb7aw2qh4f64m2d-nvf-with-helpers.drv' failed to build

Disabling vim.debugger.nvim-dap.enable in the config that i use for testing solves it, but i do not know excactly what causes it. Should the plugin be added anyways?

Additionally, would it be preferable to document all the available options to setupOpts, instead of passing {} to mkPluginSetupOption?

@LilleAila LilleAila changed the title Add mini nvim collections/mini-nvim: init Jan 16, 2025
@LilleAila LilleAila marked this pull request as ready for review January 17, 2025 08:27
@LilleAila LilleAila requested a review from NotAShelf as a code owner January 17, 2025 08:27
@NotAShelf
Copy link
Owner

I think it's best to have individual module options for each mini.nvim plugin. It's a rather rich library, and not every plugin in the suite is equally desirable.

@LilleAila
Copy link
Contributor Author

I think it's best to have individual module options for each mini.nvim plugin. It's a rather rich library, and not every plugin in the suite is equally desirable.

I agree, i'll start implementing those individually instead, and revert these changes.

@LilleAila LilleAila marked this pull request as draft January 17, 2025 16:36
@LilleAila LilleAila changed the title collections/mini-nvim: init mini-nvim: init Jan 17, 2025
@LilleAila
Copy link
Contributor Author

I think it's best to have individual module options for each mini.nvim plugin. It's a rather rich library, and not every plugin in the suite is equally desirable.

Should they all be under vim.mini.xxx, or rather be organized into their own categories?

@NotAShelf
Copy link
Owner

vim.mini.xxx sounds good.

@LilleAila LilleAila marked this pull request as ready for review January 17, 2025 20:37
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your efforts.

Two small comments to make sure we don't accidentally introduce breaking changes without asserting, or without warning the user.

modules/plugins/mini/hues/hues.nix Outdated Show resolved Hide resolved
modules/plugins/mini/notify/config.nix Outdated Show resolved Hide resolved
@NotAShelf
Copy link
Owner

On a somewhat relevant note, it might be worth adding example options for particularly complex Nix -> Lua translations at a later date. I'll keep an eye on mini suite components for options that translate weirdly.

@LilleAila LilleAila requested a review from NotAShelf January 19, 2025 09:20
@NotAShelf NotAShelf merged commit 779af80 into NotAShelf:main Jan 19, 2025
12 of 13 checks passed
@NotAShelf
Copy link
Owner

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add echasnovski/mini.nvim plugin library
2 participants