statusline/feline: init #521
Conversation
NotAShelf
force-pushed
the
feline
branch
4 times, most recently
from
77f52f7 to
b3b8d3a
Compare
| config = mkIf cfg.enable { | ||
| vim = { | ||
| lazy.plugins.feline-nvim = { | ||
| event = "UIEnter"; |
There was a problem hiding this comment.
| event = "UIEnter"; | |
| event = "DeferredUIEnter"; |
This is debatable, but if the goal is to start accepting user input as soon as possible, then DeferredUIEnter should be used
There was a problem hiding this comment.
Is there a benefit to taking user input as soon as possible?
There was a problem hiding this comment.
I mean yeah? You wouldn't want a 10s startup time would you
| enable = mkEnableOption "minimal, stylish and customizable statusline, statuscolumn, and winbar [feline.nvim]"; | ||
| setupOpts = mkPluginSetupOption "feline-nvim" { | ||
| custom_providers = mkOption { | ||
| type = attrsOf anything; |
There was a problem hiding this comment.
Should be of type luaInline
There was a problem hiding this comment.
custom_providers takes a table, in which case we should be able to get a listOf luaInline. No?
There was a problem hiding this comment.
Men go read the docs, you have to be able to refer to the custom providers somehow. It's a set of functions (which is what I meant to say in my original comment, but it ended up beibg ambiguous)
|
|
||
| disable = mkOption { | ||
| default = {}; | ||
| type = attrsOf (submodule conditionalRenderers); |
There was a problem hiding this comment.
This doesn't make sense, the defaults above only apply to force_active. Nothing should be disabled by default.
There was a problem hiding this comment.
We cannot omit the default here. That's why it has one, and also conditionalRenderers submodule provides upstream defaults.
There was a problem hiding this comment.
It literally does not, nothing is disabled by default (in the upstream detaults, which is what I meant by apply)
Adds a module for feline.nvim. Should be done, but we'd like to add examples to
components.activeandcomponents.inactivebefore this can be merged.