Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion/blink.cmp: add #510

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

horriblename
Copy link
Collaborator

@horriblename horriblename commented Dec 23, 2024

added blink.cmp

  • idk if I should keep enableSharedCmpSources
  • why do I get extra backslash sometimes when using lsp? can't repro anymore, prolly fixed upstream
  • should I raise prio of lsp snippets (i think it's deprio'd now)
    - [ ] update script (used allowBuiltinFetchGit instead)
  • lsp capabilities seems to be wrong, ldp snippets not showing
  • cmp glue stuff
  • lspkind

@horriblename horriblename force-pushed the feat-blink branch 2 times, most recently from 32f06ec to c2185f2 Compare December 26, 2024 04:46
@horriblename horriblename marked this pull request as ready for review December 26, 2024 04:46
@horriblename horriblename marked this pull request as draft December 26, 2024 04:48
@horriblename horriblename force-pushed the feat-blink branch 3 times, most recently from 4d88661 to 4602327 Compare January 1, 2025 11:01
@diniamo diniamo changed the title Feat blink completion/blink.cmp: add Jan 3, 2025
@rseichter
Copy link

This is exactly the completion plugin I was hoping for. 👍

@horriblename horriblename force-pushed the feat-blink branch 5 times, most recently from c04abc9 to b06c6c9 Compare January 11, 2025 20:06
@horriblename horriblename marked this pull request as ready for review January 11, 2025 20:50
Comment on lines +64 to +67
blink-cmp = pkgs.callPackage ./packages/blink-cmp.nix {
src = inputs.plugin-blink-cmp;
version = inputs.plugin-blink-cmp.shortRev or inputs.plugin-blink-cmp.shortDirtyRev or "dirty";
};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be better suited for the legacyPackages in the flake-parts compontent, which is propagated into our packages via overlays. See nil (and previously rnix) for how this is done.

Comment on lines +46 to +50
providers = mkOption {
type = attrsOf providerType;
default = {};
description = "Providers";
};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better description or an example wouldn't be amiss here.

github-actions bot pushed a commit that referenced this pull request Jan 19, 2025
Copy link

🚀 Live preview deployed from abd9176

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: feat-blink

Reruns: 91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants