lsp/otter: init #385
Merged
lsp/otter: init #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, not sure why it's also showing the old r commits, those have already been merged and are from another branch. No r files are being changed in this PR |
Your branch is missing changes in the main branch. Fetch Usually this would be adding a new remote (e.g. upstream) and running |
NotAShelf
requested changes
Sep 27, 2024
|
Done and tested it locally. All ok with the setupOpts implementation? I've never done it before |
NotAShelf
approved these changes
Sep 28, 2024
NotAShelf
approved these changes
Sep 28, 2024
|
All looks good. I'll merge once the CI passes. |
|
thank you :) |
bloxx12
pushed a commit
to bloxx12/nvf
that referenced
this pull request
Sep 29, 2024
* r: implementing lsp * r: version bump to context fixes treesitter bug * r: changing treesitter package definition to mkGrammarOption * added changelog entry * created otter file * created otter file * update * update * otter: fixing fixing input * committing flake.lock * fixed typo * configuration: disabling ccc and enabling otter * added assertion to make sure ccc and otter aren't enabled at the same time * configuration: otter set for isMaximal * otter: changelog * otter: better changelog * otter-nvim: renamed from otter to otter-nvim * otter: added setupopts --------- Co-authored-by: raf <[email protected]>
ppenguin
pushed a commit
to ppenguin/nvf
that referenced
this pull request
Oct 30, 2024
* r: implementing lsp * r: version bump to context fixes treesitter bug * r: changing treesitter package definition to mkGrammarOption * added changelog entry * created otter file * created otter file * update * update * otter: fixing fixing input * committing flake.lock * fixed typo * configuration: disabling ccc and enabling otter * added assertion to make sure ccc and otter aren't enabled at the same time * configuration: otter set for isMaximal * otter: changelog * otter: better changelog * otter-nvim: renamed from otter to otter-nvim * otter: added setupopts --------- Co-authored-by: raf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Support for the Otter plugin. Added an assert to prevent ccc and otter from being enabled simultaneously. Currently set Otter as on by default in Maximal config.
Type of change
Note
If Otter and ccc are both enabled, there'll be an assert
Checklist
Please try to check at least a majority of the checklist before opening your pull request. Exceptions to this will be reviewed on a case by case basis.
nix fmt).Screenshots & Logs