Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix buildPlug patches, update mnw #343

Merged
merged 4 commits into from
Jul 21, 2024
Merged

fix buildPlug patches, update mnw #343

merged 4 commits into from
Jul 21, 2024

Conversation

Gerg-L
Copy link
Contributor

@Gerg-L Gerg-L commented Jul 18, 2024

@FrothyMarrow can you test if flutter-tools works with this setup
your change of copying $src breaks patches from doing anything
i was setting version incorrectly though
i switched to stdenvNoCC.mkDerivation because it seems nicer in this case

@Gerg-L Gerg-L requested a review from NotAShelf as a code owner July 18, 2024 23:03
@Gerg-L
Copy link
Contributor Author

Gerg-L commented Jul 18, 2024

also updated mnw because i can

@FrothyMarrow
Copy link
Contributor

@Gerg-L Oh yeah I totally forgot about the patch itself. Also, I don't use flutter-tools but I think @Vagahbond can test it out.

@Vagahbond
Copy link
Contributor

I do not do Flutter sorry

@NotAShelf
Copy link
Owner

CC @FlafyDev for being a cutie and the one to add the patch

Flake lock file updates:

• Updated input 'mnw':
    'github:Gerg-L/mnw/302b18ddb8498aa9a7e0c01f7026e49d545e6898?narHash=sha256-4Z2FtCuL0lT%2BsM2gb1JMcXOUkeYrWeYZjjs1HuVTlOs%3D' (2024-07-14)
  → 'github:Gerg-L/mnw/4ea225024677e7c3a96080af8624fd3aa5dfa1b6?narHash=sha256-PF/FbgCUZ6mQrKp28G2YoVDlSThBy8AxIT9d2Ju3kTY%3D' (2024-07-20)
@NotAShelf
Copy link
Owner

Seems to build fine, though I can't verify if the patches have applied. I'll need to test with a dummy flutter project later

@FlafyDev
Copy link
Contributor

i can test
can i get nvf with flutter support through a cli command?

@NotAShelf
Copy link
Owner

i can test can i get nvf with flutter support through a cli command?

Unfortunately, no. But you can initialize a quick configuration using the extended library and a very basic flake:

{
  inputs = {
    nixpkgs.url = "github:nixos/nixpkgs?ref=nixos-unstable";
    nvf.url = "github:notashelf/nvf";
  };

  outputs = inputs: let
    system = "x86_64-linux";
    pkgs = inputs.nixpkgs.legacyPackages.${system};

    customNeovim = inputs.nvf.lib.neovimConfiguration {
      inherit pkgs;

      modules = [
        {
          config.vim = {
            languages.dart = {
              enable = true;
              dap.enable = true;
            };
          };
        }
      ];
    };
  in {
    packages.${system}.neovim = customNeovim.neovim;
  };
}

@FlafyDev
Copy link
Contributor

doesn't seem to work
image

@NotAShelf
Copy link
Owner

My bad I missed a few lines. Please try this @FlafyDev

{
  inputs = {
    nixpkgs.url = "github:nixos/nixpkgs?ref=nixos-unstable";
    nvf.url = "github:gerg-l/nvf";
  };

  outputs = inputs: let
    system = "x86_64-linux";
    pkgs = inputs.nixpkgs.legacyPackages.${system};

    customNeovim = inputs.nvf.lib.neovimConfiguration {
      inherit pkgs;

      modules = [
        {
          config.vim = {
            startPlugins = [pkgs.vimPlugins.plenary-nvim];
            languages.dart = {
              enable = true;
              lsp.enable = false;
              treesitter.enable = true;
              flutter-tools = {
                enable = true;
                color = {
                  enable = true;
                  virtualText.enable = true;
                };
              };
            };
          };
        }
      ];
    };
  in {
    packages.${system}.neovim = customNeovim.neovim;
  };
}

@FlafyDev
Copy link
Contributor

works 👍
image

@NotAShelf NotAShelf merged commit 589b86d into NotAShelf:main Jul 21, 2024
7 checks passed
bloxx12 pushed a commit to bloxx12/nvf that referenced this pull request Sep 29, 2024
* bald frog (gerg-l)

* modules/default.nix: make patches work on built plugins

* flake.lock: Update

Flake lock file updates:

• Updated input 'mnw':
    'github:Gerg-L/mnw/302b18ddb8498aa9a7e0c01f7026e49d545e6898?narHash=sha256-4Z2FtCuL0lT%2BsM2gb1JMcXOUkeYrWeYZjjs1HuVTlOs%3D' (2024-07-14)
  → 'github:Gerg-L/mnw/4ea225024677e7c3a96080af8624fd3aa5dfa1b6?narHash=sha256-PF/FbgCUZ6mQrKp28G2YoVDlSThBy8AxIT9d2Ju3kTY%3D' (2024-07-20)

---------

Co-authored-by: raf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants