Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow benchmark dry-runs in CI #1217

Merged
merged 1 commit into from
Jan 9, 2025
Merged

allow benchmark dry-runs in CI #1217

merged 1 commit into from
Jan 9, 2025

Conversation

OmarTawfik
Copy link
Contributor

No description provided.

@OmarTawfik OmarTawfik requested review from a team as code owners January 9, 2025 17:31
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e643230

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik marked this pull request as draft January 9, 2025 17:36
@OmarTawfik OmarTawfik force-pushed the ci-benchmark-dry-run branch 2 times, most recently from b3f0bb1 to 032b88d Compare January 9, 2025 17:38
@OmarTawfik OmarTawfik force-pushed the ci-benchmark-dry-run branch from 032b88d to e643230 Compare January 9, 2025 17:40
@OmarTawfik OmarTawfik marked this pull request as ready for review January 9, 2025 18:17
@OmarTawfik OmarTawfik enabled auto-merge January 9, 2025 18:18
beta-ziliani
beta-ziliani approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OmarTawfik OmarTawfik added this pull request to the merge queue Jan 9, 2025
Merged via the queue into NomicFoundation:main with commit 2fda675 Jan 9, 2025
1 check passed
@OmarTawfik OmarTawfik deleted the ci-benchmark-dry-run branch January 9, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarTawfik @beta-ziliani