Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dex2jar: init at 2.0 #88425

Merged
merged 1 commit into from
May 28, 2020
Merged

dex2jar: init at 2.0 #88425

merged 1 commit into from
May 28, 2020

Conversation

makefu
Copy link
Contributor

@makefu makefu commented May 20, 2020

Motivation for this change

Add dex2jar from my local NUR to nixpkgs. dex2jar is a tool requested in #81418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@makefu makefu force-pushed the pkgs/dex2jar/init branch from 5b5b06c to 60d1f13 Compare May 20, 2020 12:52
@makefu
Copy link
Contributor Author

makefu commented May 20, 2020

@GrahamcOfBorg build dex2jar

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 20, 2020
@makefu makefu force-pushed the pkgs/dex2jar/init branch from 60d1f13 to e682df2 Compare May 28, 2020 06:31
@makefu
Copy link
Contributor Author

makefu commented May 28, 2020

thanks for the review!

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label May 28, 2020
@Mic92
Copy link
Member

Mic92 commented May 28, 2020

Result of nixpkgs-review pr 88425 1

1 package built:
- dex2jar

@Mic92 Mic92 merged commit 1b81b55 into NixOS:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzzlewolf puzzlewolf puzzlewolf left review comments

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makefu @Mic92 @puzzlewolf