Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-24.11] nitrokey: 0.2.3 -> 0.2.4 #376591

Merged
merged 1 commit into from
Jan 25, 2025
Merged

[Backport release-24.11] nitrokey: 0.2.3 -> 0.2.4 #376591

merged 1 commit into from
Jan 25, 2025

Conversation

nixpkgs-ci[bot]
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Jan 25, 2025 •
edited by NickCao
Loading

Bot-based backport to release-24.11, triggered by a label in #375776.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@r-vdp @github-actions
nitrokey: 0.2.3 -> 0.2.4
07e1494 
This fixes the build failure on master,
see Nitrokey/nitrokey-sdk-py#60

(cherry picked from commit e171f54)
@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 25, 2025
Merged
13 tasks
panicgh
panicgh approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@panicgh panicgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376591

x86_64-linux

✅ 11 packages built:
  • nitrokey-app2
  • nitrokey-app2.dist
  • nitrokey-fido2-firmware
  • pynitrokey (python312Packages.pynitrokey)
  • pynitrokey.dist (python312Packages.pynitrokey.dist)
  • python311Packages.nitrokey
  • python311Packages.nitrokey.dist
  • python311Packages.pynitrokey
  • python311Packages.pynitrokey.dist
  • python312Packages.nitrokey
  • python312Packages.nitrokey.dist

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 25, 2025
@NickCao NickCao merged commit 72c6d64 into release-24.11 Jan 25, 2025
26 of 28 checks passed
@r-vdp r-vdp deleted the backport-375776-to-release-24.11 branch January 26, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panicgh panicgh panicgh approved these changes

Assignees
No one assigned
Labels
6.topic: python 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panicgh @wegank @NickCao @r-vdp