Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octave: fix cross build #375025

Merged
merged 1 commit into from
Jan 19, 2025
Merged

octave: fix cross build #375025

merged 1 commit into from
Jan 19, 2025
+5 −1

Conversation

FliegendeWurst
Copy link
Member

Also fixes regular strictDeps build, ref. #178468

Things done

  • Built on platform(s)
    • x86_64-linux: and cross to aarch64
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jan 19, 2025
@FliegendeWurst FliegendeWurst added the 3.skill: trivial This is trivial to complete (typically find-and-replace) label Jan 19, 2025
@nix-owners nix-owners bot requested review from doronbehar and 7c6f434c January 19, 2025 11:31
doronbehar
doronbehar reviewed Jan 19, 2025
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and for working on strictDeps enabling in general!

pkgs/development/interpreters/octave/default.nix Show resolved Hide resolved
@doronbehar doronbehar merged commit e272e72 into NixOS:master Jan 19, 2025
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
3.skill: trivial This is trivial to complete (typically find-and-replace) 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FliegendeWurst @SuperSandro2000 @doronbehar