Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solc: remove Z3 version hardcoding #374928

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

solc: remove Z3 version hardcoding #374928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions pkgs/by-name/so/solc/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
python3,
versionCheckHook,
z3Support ? true,
z3_4_11 ? null,
z3 ? null,
cvc4Support ? gccStdenv.hostPlatform.isLinux,
cvc4 ? null,
cln ? null,
Expand All @@ -19,10 +19,6 @@

# compiling source/libsmtutil/CVC4Interface.cpp breaks on clang on Darwin,
# general commandline tests fail at abiencoderv2_no_warning/ on clang on NixOS
let
z3 = z3_4_11;
in

assert z3Support -> z3 != null && lib.versionAtLeast z3.version "4.11.0";
assert cvc4Support -> cvc4 != null && cln != null && gmp != null;

Expand Down Expand Up @@ -125,6 +121,8 @@ let
))
]; # contextlib2 glob2 textwrap3 traceback2 urllib3

enableParallelBuilding = true;

# tests take 60+ minutes to complete, only run as part of passthru tests
doCheck = false;

Expand Down