Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lact: 0.6.0 -> 0.7.0 #374771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

lact: 0.6.0 -> 0.7.0 #374771

wants to merge 1 commit into from
+16 −5

Conversation

cything
Copy link
Contributor

@cything cything commented Jan 18, 2025

Things done

Changelog: https://github.com/ilya-zlobintsev/LACT/releases/tag/v0.7.0

Also added nix-update-script to passthru.updateScript and tested that it works.

I couldn't get tests::snapshot_everything to pass. Maybe you need to have some specific GPU hardware (AMD?) to get it work? If you have any pointers, please let me know.

Resolves #374358

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 18, 2025
@nix-owners nix-owners bot requested review from Atemu and figsoda January 18, 2025 10:44
@aucub
Copy link
Contributor

aucub commented Jan 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374771

x86_64-linux

✅ 1 package built:
  • lact

Atemu
Atemu approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM but I'm currently not near my machine where I use LACT.

Could you described what you tested to be working?

pkgs/by-name/la/lact/package.nix
@@ -43,6 +45,7 @@ rustPlatform.buildRustPackage rec {
checkFlags = [
# tries and fails to initialize gtk
"--skip=app::pages::thermals_page::fan_curve_frame::tests::set_get_curve"
"--skip=tests::snapshot_everything"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you report this upstream and add a back reference?

Or at least a comment why this fails.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really understand why the test is failing tbh. Here's some logs:

2025-01-18T19:02:36.867269Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:36.867441Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:36.867527Z  INFO lact_daemon::server::handler: initialized radeon controller for GPU 1002:6818-174B:E217-0000:01:00.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/amd/hd7870/card0/device'
2025-01-18T19:02:36.867809Z  INFO lact_daemon::server::handler: initialized 1 GPUs
test config::tests::parse_doc ... ok
stored new snapshot /home/yt/fun/LACT/lact-daemon/src/tests/snapshots/lact_daemon__tests__amd__hd7870.snap.new
2025-01-18T19:02:36.936453Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:36.936639Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:36.936741Z  INFO lact_daemon::server::handler: initialized amdgpu controller for GPU 1002:679A-1458:229A-0000:01:00.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/amd/r9-280/card0/device'
2025-01-18T19:02:36.937053Z  INFO lact_daemon::server::handler: initialized 1 GPUs
stored new snapshot /home/yt/fun/LACT/lact-daemon/src/tests/snapshots/lact_daemon__tests__amd__r9-280.snap.new
2025-01-18T19:02:36.978342Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:36.978644Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:36.978825Z  INFO lact_daemon::server::handler: initialized amdgpu controller for GPU 1002:731F-1DA2:E409-0000:28:00.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/amd/rx5700xt/card1/device'
2025-01-18T19:02:36.979254Z  INFO lact_daemon::server::handler: initialized 1 GPUs
stored new snapshot /home/yt/fun/LACT/lact-daemon/src/tests/snapshots/lact_daemon__tests__amd__rx5700xt.snap.new
2025-01-18T19:02:37.025115Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:37.025401Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:37.025600Z  INFO lact_daemon::server::handler: initialized amdgpu controller for GPU 1002:67DF-1DA2:E387-0000:09:00.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/amd/rx580/card0/device'
2025-01-18T19:02:37.026048Z  INFO lact_daemon::server::handler: initialized 1 GPUs
stored new snapshot /home/yt/fun/LACT/lact-daemon/src/tests/snapshots/lact_daemon__tests__amd__rx580.snap.new
2025-01-18T19:02:37.069399Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:37.069617Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:37.069770Z  INFO lact_daemon::server::handler: initialized amdgpu controller for GPU 1002:73FF-1EAE:6505-0000:0b:00.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/amd/rx6600xt/card0/device'
2025-01-18T19:02:37.070103Z  INFO lact_daemon::server::handler: initialized 1 GPUs
stored new snapshot /home/yt/fun/LACT/lact-daemon/src/tests/snapshots/lact_daemon__tests__amd__rx6600xt.snap.new
2025-01-18T19:02:37.114193Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:37.114360Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:37.115478Z  INFO lact_daemon::server::handler: initialized amdgpu controller for GPU 1002:73BF-1DA2:440E-0000:0c:00.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/amd/rx6900xt/card0/device'
2025-01-18T19:02:37.116093Z  INFO lact_daemon::server::handler: initialized 1 GPUs
stored new snapshot /home/yt/fun/LACT/lact-daemon/src/tests/snapshots/lact_daemon__tests__amd__rx6900xt.snap.new
2025-01-18T19:02:37.173972Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:37.174187Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:37.174347Z  INFO lact_daemon::server::handler: initialized amdgpu controller for GPU 1002:7480-F111:0007-0000:03:00.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/amd/rx7700s/card1/device'
2025-01-18T19:02:37.174624Z  INFO lact_daemon::server::handler: initialized 1 GPUs
stored new snapshot /home/yt/fun/LACT/lact-daemon/src/tests/snapshots/lact_daemon__tests__amd__rx7700s.snap.new
2025-01-18T19:02:37.216746Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:37.216892Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:37.216970Z  INFO lact_daemon::server::handler: initialized amdgpu controller for GPU 1002:744C-1DA2:E471-0000:03:00.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/amd/rx7900xt/card0/device'
2025-01-18T19:02:37.217349Z  INFO lact_daemon::server::handler: initialized 1 GPUs
stored new snapshot /home/yt/fun/LACT/lact-daemon/src/tests/snapshots/lact_daemon__tests__amd__rx7900xt.snap.new
2025-01-18T19:02:37.261853Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:37.262023Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:37.262174Z  INFO lact_daemon::server::handler: initialized amdgpu controller for GPU 1002:163F-1002:0123-0000:04:00.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/amd/vangogh/card0/device'
2025-01-18T19:02:37.262446Z  INFO lact_daemon::server::handler: initialized 1 GPUs
stored new snapshot /home/yt/fun/LACT/lact-daemon/src/tests/snapshots/lact_daemon__tests__amd__vangogh.snap.new
2025-01-18T19:02:37.303623Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:37.303793Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:37.303895Z  INFO lact_daemon::server::handler: initialized amdgpu controller for GPU 1002:687F-1043:0555-0000:0b:00.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/amd/vega56/card0/device'
2025-01-18T19:02:37.304391Z  INFO lact_daemon::server::handler: initialized 1 GPUs
stored new snapshot /home/yt/fun/LACT/lact-daemon/src/tests/snapshots/lact_daemon__tests__amd__vega56.snap.new
2025-01-18T19:02:37.347324Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:37.347453Z ERROR lact_daemon::server::handler: failed to initialize Intel DRM: libdrm_intel.so.1: cannot open shared object file: No such file or directory
2025-01-18T19:02:37.347469Z ERROR lact_daemon::server::gpu_controller: Intel DRM library missing, Intel controls will not be available
2025-01-18T19:02:37.347494Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:37.347602Z  INFO lact_daemon::server::handler: initialized i915 controller for GPU 8086:56A5-1849:6004-0000:0b:00.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/intel/a380-i915/card1/device'
2025-01-18T19:02:37.348093Z  INFO lact_daemon::server::handler: initialized 1 GPUs
stored new snapshot /home/yt/fun/LACT/lact-daemon/src/tests/snapshots/lact_daemon__tests__intel__a380-i915.snap.new
2025-01-18T19:02:37.390743Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:37.390871Z ERROR lact_daemon::server::handler: failed to initialize Intel DRM: libdrm_intel.so.1: cannot open shared object file: No such file or directory
2025-01-18T19:02:37.390893Z ERROR lact_daemon::server::gpu_controller: Intel DRM library missing, Intel controls will not be available
2025-01-18T19:02:37.390915Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:37.390984Z  INFO lact_daemon::server::handler: initialized xe controller for GPU 8086:56A5-1849:6004-0000:0b:00.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/intel/a380-xe/card0/device'
2025-01-18T19:02:37.391257Z  INFO lact_daemon::server::handler: initialized 1 GPUs
stored new snapshot /home/yt/fun/LACT/lact-daemon/src/tests/snapshots/lact_daemon__tests__intel__a380-xe.snap.new
2025-01-18T19:02:37.432986Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:37.433221Z ERROR lact_daemon::server::handler: failed to initialize Intel DRM: libdrm_intel.so.1: cannot open shared object file: No such file or directory
2025-01-18T19:02:37.433233Z ERROR lact_daemon::server::gpu_controller: Intel DRM library missing, Intel controls will not be available
2025-01-18T19:02:37.433254Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:37.433299Z  INFO lact_daemon::server::handler: initialized i915 controller for GPU 8086:9B41-17AA:22B1-0000:00:02.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/intel/cometlake/card0/device'
2025-01-18T19:02:37.433575Z  INFO lact_daemon::server::handler: initialized 1 GPUs
stored new snapshot /home/yt/fun/LACT/lact-daemon/src/tests/snapshots/lact_daemon__tests__intel__cometlake.snap.new
2025-01-18T19:02:37.474967Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:37.475134Z ERROR lact_daemon::server::handler: failed to initialize Intel DRM: libdrm_intel.so.1: cannot open shared object file: No such file or directory
2025-01-18T19:02:37.475149Z ERROR lact_daemon::server::gpu_controller: Intel DRM library missing, Intel controls will not be available
2025-01-18T19:02:37.475179Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:37.475237Z  INFO lact_daemon::server::handler: initialized xe controller for GPU 8086:9A49-17AA:3F19-0000:00:02.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/intel/tigerlake/card0/device'
2025-01-18T19:02:37.475633Z  INFO lact_daemon::server::handler: initialized 1 GPUs
stored new snapshot /home/yt/fun/LACT/lact-daemon/src/tests/snapshots/lact_daemon__tests__intel__tigerlake.snap.new
2025-01-18T19:02:37.516685Z  WARN lact_daemon::server::handler: could not read PCI ID database: file not found, device information will be limited
2025-01-18T19:02:37.516763Z ERROR lact_daemon::server::gpu_controller: NVML is missing, Nvidia controls will not be available
2025-01-18T19:02:37.516816Z ERROR lact_daemon::server::handler: failed to initialize AMDGPU DRM: libdrm.so: cannot open shared object file: No such file or directory, some functionality will be missing
2025-01-18T19:02:37.516875Z  INFO lact_daemon::server::handler: initialized nvidia controller for GPU 10DE:2704-1462:5110-0000:09:00.0 at '/home/yt/fun/LACT/lact-daemon/src/tests/data/nvidia/rtx4080/card1/device'
2025-01-18T19:02:37.517344Z  INFO lact_daemon::server::handler: initialized 1 GPUs

@Atemu Atemu mentioned this pull request Jan 18, 2025
Open
3 tasks
@cything
Copy link
Contributor Author

cything commented Jan 18, 2025 •
edited
Loading

Could you described what you tested to be working?

@Atemu
This upgrade was performed by the script. I had to skip the test and add a new hook to get it to pass, but I assume that's expected? Or should I remove it? (if the script is unlikely to work in the future).

@Atemu
Copy link
Member

Atemu commented Jan 18, 2025

I meant what parts of the updated program you tried to run and found to be working correctly. Basically I want to ascertain that the program still functions as expected after the update.

@cything
Copy link
Contributor Author

cything commented Jan 18, 2025

@Atemu
I have a regular integrated GPU and it seems to be working fine as far as I can tell. Working on fixing the test; I think I may have a clue.

image
image

@Atemu
Copy link
Member

Atemu commented Jan 18, 2025

I'd like to see its core functionality such as fan curves or OC to be tested before we merge.

@cything cything force-pushed the lact branch 2 times, most recently from 837cccb to 5d2d383 Compare January 18, 2025 22:28
Atemu
Atemu requested changes Jan 18, 2025
View reviewed changes
pkgs/by-name/la/lact/package.nix Outdated
Comment on lines 70 to 75
--add-needed ${vulkan-loader}/lib/libvulkan.so \
--add-needed ${libdrm}/lib/libdrm.so \
--add-needed ${libdrm}/lib/libdrm_intel.so \
--add-needed ${libdrm}/lib/libdrm_amdgpu.so \
--add-needed ${libdrm}/lib/libdrm_radeon.so \
--add-needed ${libdrm}/lib/libdrm_nouveau.so \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a needed for libdrm.so (like I had for libvulkan.so before) and add it to the library path.

These do not make sense to declare here; they're loaded at runtime.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about that. done.

@cything
lact: 0.6.0 -> 0.7.0
5a86bac 
changelog: https://github.com/ilya-zlobintsev/LACT/releases/tag/v0.7.0

also add nix-update-script to passthru.updateScript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aucub aucub aucub left review comments

@Atemu Atemu Atemu requested changes

@figsoda figsoda Awaiting requested review from figsoda

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Request: lact 0.6.0 → 0.7.0
3 participants
@cything @aucub @Atemu