Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schismtracker: 20240809 -> 20241226 #374726

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cything
Copy link
Contributor

@cything cything commented Jan 18, 2025

Things done

Changelog: https://github.com/schismtracker/schismtracker/releases/tag/20241226

Also added nix-update-script and tested that it works

Resolves #373016

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@OPNA2608
Copy link
Contributor

OPNA2608 commented Jan 18, 2025

Fails to launch for me:

↪ schismtracker
Creating directory /home/puna/.config/schism
Schism Tracker uses this directory to store your settings.
Critical error!: Failed to initialize a timers backend!

@OPNA2608
Copy link
Contributor

OPNA2608 commented Jan 18, 2025

To fix the above, please revamp configureFlags as follows:

  configureFlags =
    [ 
      (lib.enableFeature true "dependency-tracking")
      (lib.withFeature true "sdl2")
      (lib.enableFeature true "sdl2-linking")
    ]     
    ++ lib.optionals stdenv.hostPlatform.isLinux [
      (lib.withFeature true "alsa")
      (lib.enableFeature true "alsa-linking")
    ]     
    ++ lib.optionals stdenv.hostPlatform.isDarwin [
      (lib.enableFeature false "sdltest")
    ];

@cything
Copy link
Contributor Author

cything commented Jan 18, 2025

Thanks! Should be working now.

Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374726


x86_64-linux

✅ 1 package built:
  • schismtracker

Tested loading some MOD & XM files, LGTM.

@OPNA2608 OPNA2608 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update request: schismtracker 20240809 → 20241226
2 participants