Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peazip: removed insecure and redundant dependency #374566

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

peazip: removed insecure and redundant dependency #374566

wants to merge 1 commit into from
+0 −2

Conversation

auroraanna
Copy link
Contributor

@auroraanna auroraanna commented Jan 17, 2025 •
edited
Loading

fixes #374507

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@auroraanna auroraanna self-assigned this Jan 17, 2025
@auroraanna
Copy link
Contributor Author

all the formats except arc were already supported by the other packages included and arc doesn't even work with archiver.

donovanglover
donovanglover reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed -> remove in the commit message

pkgs/by-name/pe/peazip/package.nix Show resolved Hide resolved
@donovanglover
Copy link
Member

Could mention archiver in the commit message as well

@auroraanna
Copy link
Contributor Author

removed -> remove in the commit message

it hasn't found this in the commit conventions except that one example is "init at version", not "init(iat)ed at version"

@auroraanna auroraanna force-pushed the peazip branch 2 times, most recently from 94c97e7 to 38929c7 Compare January 18, 2025 23:30
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 18, 2025
ProxyVT
ProxyVT approved these changes Jan 19, 2025
View reviewed changes
Copy link

@ProxyVT ProxyVT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProxyVT ProxyVT ProxyVT approved these changes

@donovanglover donovanglover Awaiting requested review from donovanglover

Assignees

@auroraanna auroraanna

Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

peazip: remove/replace archiver dependency (CVE-2024-0406)
3 participants
@auroraanna @donovanglover @ProxyVT