-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jellyfin-tui: init at v1.0.5 #374176
base: master
Are you sure you want to change the base?
jellyfin-tui: init at v1.0.5 #374176
Changes from 2 commits
9449907
52c9e0b
12bbecf
c8a9129
4dac4b2
9805d29
d03bb46
5b67e70
59608cb
4de4537
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8461,6 +8461,11 @@ | |
githubId = 60962839; | ||
name = "Mazen Zahr"; | ||
}; | ||
GKHWB = { | ||
github = "GKHWB"; | ||
githubId = 68881230; | ||
name = "GKHWB"; | ||
}; | ||
gkleen = { | ||
name = "Gregor Kleen"; | ||
email = "[email protected]"; | ||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,35 @@ | ||||||
{ | ||||||
lib, | ||||||
fetchFromGitHub, | ||||||
rustPlatform, | ||||||
pkg-config, | ||||||
openssl, | ||||||
mpv, | ||||||
}: | ||||||
|
||||||
rustPlatform.buildRustPackage rec { | ||||||
pname = "jellyfin-tui"; | ||||||
version = "v1.0.5"; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do not use
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed the v from version and concatenated v with version in the fetcher itself, not sure if that's the proper way to do it though. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That is exactly it. Sorry, I should have clarified. Only, string interpolation is easier to type and much more concise. |
||||||
|
||||||
src = fetchFromGitHub { | ||||||
GKHWB marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
owner = "dhonus"; | ||||||
repo = pname; | ||||||
GKHWB marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
rev = version; | ||||||
GKHWB marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
hash = "sha256-dME3oM3k5TGjN8S/93Crt3vw8+KjZWivkVzg+eqwfe4="; | ||||||
}; | ||||||
|
||||||
cargoHash = "sha256-hogGwkaNDE4yPYgmmG9wfDPlNTUaVqlJzCW31lrX6Ic="; | ||||||
|
||||||
meta = { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this is an application, add |
||||||
description = "tui music client for jellyfin"; | ||||||
GKHWB marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
homepage = "https://github.com/dhonus/jellyfin-tui"; | ||||||
license = lib.licenses.gpl3; | ||||||
maintainers = with lib.maintainers; [ GKHWB ]; | ||||||
}; | ||||||
|
||||||
nativeBuildInputs = [ pkg-config ]; | ||||||
buildInputs = [ | ||||||
openssl | ||||||
mpv | ||||||
]; | ||||||
GKHWB marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion, not necessary: When we are at it, would you be OK with adding some additional means of contacting you? Matrix, email? It is easier when it is needed than GitHub.