Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jellyfin-tui: init at v1.0.5 #374176

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
5 changes: 5 additions & 0 deletions maintainers/maintainer-list.nix
Original file line number Diff line number Diff line change
Expand Up @@ -8461,6 +8461,11 @@
githubId = 60962839;
name = "Mazen Zahr";
};
GKHWB = {
github = "GKHWB";
githubId = 68881230;
name = "GKHWB";
};
Comment on lines +8464 to +8468
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion, not necessary: When we are at it, would you be OK with adding some additional means of contacting you? Matrix, email? It is easier when it is needed than GitHub.

gkleen = {
name = "Gregor Kleen";
email = "[email protected]";
Expand Down
35 changes: 35 additions & 0 deletions pkgs/by-name/je/jellyfin-tui/package.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
lib,
fetchFromGitHub,
rustPlatform,
pkg-config,
openssl,
mpv,
}:

rustPlatform.buildRustPackage rec {
pname = "jellyfin-tui";
version = "v1.0.5";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use v here. Use it only in the fetcher.

Suggested change
version = "v1.0.5";
version = "1.0.5";

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the v from version and concatenated v with version in the fetcher itself, not sure if that's the proper way to do it though.

Copy link
Contributor

@Adda0 Adda0 Jan 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is exactly it. Sorry, I should have clarified. Only, string interpolation is easier to type and much more concise.


src = fetchFromGitHub {
GKHWB marked this conversation as resolved.
Show resolved Hide resolved
owner = "dhonus";
repo = pname;
GKHWB marked this conversation as resolved.
Show resolved Hide resolved
rev = version;
GKHWB marked this conversation as resolved.
Show resolved Hide resolved
hash = "sha256-dME3oM3k5TGjN8S/93Crt3vw8+KjZWivkVzg+eqwfe4=";
};

cargoHash = "sha256-hogGwkaNDE4yPYgmmG9wfDPlNTUaVqlJzCW31lrX6Ic=";

meta = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an application, add meta.mainProgram attribute.

description = "tui music client for jellyfin";
GKHWB marked this conversation as resolved.
Show resolved Hide resolved
homepage = "https://github.com/dhonus/jellyfin-tui";
license = lib.licenses.gpl3;
maintainers = with lib.maintainers; [ GKHWB ];
};

nativeBuildInputs = [ pkg-config ];
buildInputs = [
openssl
mpv
];
GKHWB marked this conversation as resolved.
Show resolved Hide resolved
}