Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gqlgen: init at 0.17.63 #374121

Merged
merged 2 commits into from
Jan 16, 2025
Merged

gqlgen: init at 0.17.63 #374121

merged 2 commits into from
Jan 16, 2025

Conversation

skowalak
Copy link
Contributor

@skowalak skowalak commented Jan 15, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 15, 2025
@skowalak
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


aarch64-darwin

✅ 1 package built:
  • gqlgen

@katexochen
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374121


x86_64-linux

✅ 1 package built:
  • gqlgen

@skowalak skowalak force-pushed the master branch 2 times, most recently from e97f1d0 to 9e8418b Compare January 15, 2025 20:10
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Feel free to ping in a couple days if there are no other reviews :)

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374121


aarch64-linux

✅ 1 package built:
  • gqlgen

pkgs/by-name/gq/gqlgen/package.nix Show resolved Hide resolved
@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 16, 2025
@katexochen katexochen merged commit 1bda1e5 into NixOS:master Jan 16, 2025
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants