Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrypted: init at 0.126.0 #373883

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

scrypted: init at 0.126.0 #373883

wants to merge 7 commits into from

Conversation

omares
Copy link
Contributor

@omares omares commented Jan 14, 2025

Init scrypted package and service at version 0.126.0

This resolves #220494

The installation procedure is based on Scrypted's Docker file. I have omitted the generic installation of the graphical or TPU drivers, as I believe the user knows best what is needed for their case.

I provided a custom build hook to skip the NPM rebuild phase, as it fails due to issues with node-addon-api.
See #372605.
The inability to build the @scrypted/node-pty NPM package prevents scrypted's terminal feature from functioning, while all other features remain available. Though I don't view this as a downside, as terminal access through a Node app could be considered a security risk. Regardless, it would be great to resolve the build problem - if possible.

During a dummy setup of scrypted locally, I am able to install plugins and see camera streams.

I would appreciate it if someone else could also run the test checks for building and running the package, as this is my first proper contribution.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md. (at least i hope so :))

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 14, 2025
@omares
Copy link
Contributor Author

omares commented Jan 14, 2025

Should the package maybe be called scrypted-server? As it does not consider the other sources like the SDK or plugins (which are installed via the UI).

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 14, 2025
@omares
Copy link
Contributor Author

omares commented Jan 14, 2025

Should formatting happen through nixfmt-classic or nixfmt-rfc-style?
I did format the files using nixfmt (classic) as mentioned in the failing job.

nixfmt-rfc-style it is

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Jan 15, 2025
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 16, 2025
@sikmir
Copy link
Member

sikmir commented Jan 17, 2025

Please rebase to keep 3 commits:

maintainers: add omares
scrypted: init at 0.127.1
nixos/scrypted: init

@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Scrypted
3 participants